Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: Source/core/accessibility/AXObject.h

Issue 588653003: Adding support for ARIA 1.1 role="none" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/accessibility/AXObject.h
diff --git a/Source/core/accessibility/AXObject.h b/Source/core/accessibility/AXObject.h
index 951ca30e2772b6a6ce9b3737ff70ce4464014958..f81f591d5aa12c943e9fee43a5055d37595169e1 100644
--- a/Source/core/accessibility/AXObject.h
+++ b/Source/core/accessibility/AXObject.h
@@ -126,6 +126,7 @@ enum AccessibilityRole {
MenuListPopupRole,
MenuRole,
NavigationRole,
+ NoneRole,
NoteRole,
OutlineRole,
ParagraphRole,
@@ -434,9 +435,9 @@ public:
virtual String ariaLabeledByAttribute() const { return String(); }
bool ariaPressedIsPresent() const;
virtual AccessibilityRole ariaRoleAttribute() const { return UnknownRole; }
- virtual bool ariaRoleHasPresentationalChildren() const { return false; }
+ virtual bool ariaRoleHasNoneOrPresentationalChildren() const { return false; }
shreeramk 2014/09/20 12:39:36 Should I go ahead with above modified function nam
dmazzoni 2014/09/22 06:12:23 My vote is to leave it alone - ariaRoleHasPresenta
virtual bool isARIAGrabbed() { return false; }
- virtual bool isPresentationalChildOfAriaRole() const { return false; }
+ virtual bool isNoneOrPresentationalChildOfAriaRole() const { return false; }
shreeramk 2014/09/20 12:39:36 Should I go ahead with above modified function nam
virtual bool shouldFocusActiveDescendant() const { return false; }
bool supportsARIAAttributes() const;
virtual bool supportsARIADragging() const { return false; }

Powered by Google App Engine
This is Rietveld 408576698