Issue 58863002: Update Views bubble frames on Windows theme changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 58863002: Update Views bubble frames on Windows theme changes. (Closed)

Created:
7 years, 1 month ago by msw

Modified:
7 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, msw+watch_chromium.org, alicet1, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update Views bubble frames on Windows theme changes. Update content on Windows theme changes (Glass->Classic). Implement BubbleFrameView::OnThemeChanged to fix title/close. Called via NonClientView::UpdateFrame after being clobbered. BUG=308262 TEST=Dialogs retain their title and close button after windows theme changes. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233150

Patch Set 1 #

Patch Set 2 : Simplify changes. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	ui/views/bubble/bubble_frame_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	ui/views/bubble/bubble_frame_view.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/58863002/30001

7 years, 1 month ago (2013-11-05 15:48:19 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=185140

7 years, 1 month ago (2013-11-05 17:45:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/58863002/30001

7 years, 1 month ago (2013-11-05 18:01:47 UTC) #5

Message was sent while issue was closed.

Change committed as 233150

Expand Messages | Collapse Messages