Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 588573003: Expect InitSegmentReceived() in PipelineIntegrationTest.Encrypted* tests. (Closed)

Created:
6 years, 2 months ago by xhwang
Modified:
6 years, 2 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Expect InitSegmentReceived() in PipelineIntegrationTest.Encrypted* tests. This is a follow up of 37e3ddb2, which introduced the InitSegmentReceived() call. Since StartPipelineWithEncryptedMedia() also uses MockMediaSource, we should also expect InitSegmentReceived() to be called. Otherwise, we'll receive warnings about uninterested mock calls of InitSegmentReceived(). BUG=249428 TEST=This fixes expectations in existing tests. Committed: https://crrev.com/7f437453187214d5ee1dda4c075727a342d55edc Cr-Commit-Position: refs/heads/master@{#296099}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/filters/pipeline_integration_test.cc View 1 chunk +1 line, -0 lines 3 comments Download

Messages

Total messages: 9 (2 generated)
xhwang
PTAL
6 years, 2 months ago (2014-09-22 21:12:26 UTC) #2
wolenetz
lgtm (oops, I let those warnings in! Thanks for fixing!) There's a drive-by nit that's ...
6 years, 2 months ago (2014-09-22 23:25:27 UTC) #3
xhwang
https://codereview.chromium.org/588573003/diff/1/media/filters/pipeline_integration_test.cc File media/filters/pipeline_integration_test.cc (right): https://codereview.chromium.org/588573003/diff/1/media/filters/pipeline_integration_test.cc#newcode1162 media/filters/pipeline_integration_test.cc:1162: // Config changes from encrypted to clear are not ...
6 years, 2 months ago (2014-09-22 23:40:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588573003/1
6 years, 2 months ago (2014-09-22 23:41:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as da9143fff8e2fbeace47272d571cb414150adbc4
6 years, 2 months ago (2014-09-22 23:49:17 UTC) #7
wolenetz
https://codereview.chromium.org/588573003/diff/1/media/filters/pipeline_integration_test.cc File media/filters/pipeline_integration_test.cc (right): https://codereview.chromium.org/588573003/diff/1/media/filters/pipeline_integration_test.cc#newcode1162 media/filters/pipeline_integration_test.cc:1162: // Config changes from encrypted to clear are not ...
6 years, 2 months ago (2014-09-22 23:49:37 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-22 23:49:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f437453187214d5ee1dda4c075727a342d55edc
Cr-Commit-Position: refs/heads/master@{#296099}

Powered by Google App Engine
This is Rietveld 408576698