Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 588573002: Optimize Function.prototype.call (Closed)

Created:
6 years, 3 months ago by p.antonov
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+581 lines, -71 lines) Patch
M src/hydrogen.h View 3 chunks +13 lines, -8 lines 0 comments Download
M src/hydrogen.cc View 11 chunks +131 lines, -42 lines 1 comment Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/compiler/deopt-inlined-from-call.js View 1 chunk +154 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/inlined-call.js View 1 chunk +190 lines, -0 lines 0 comments Download
A + test/mjsunit/compiler/inlined-call-mapcheck.js View 2 chunks +22 lines, -21 lines 0 comments Download
A test/mjsunit/regress/regress-385565.js View 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
p.antonov
As per https://codereview.chromium.org/350913002/, added deoptimization tests for paths where simulates are used
6 years, 3 months ago (2014-09-19 14:11:13 UTC) #1
p.antonov
PTAL
6 years, 3 months ago (2014-09-24 08:29:52 UTC) #2
p.antonov
PTAL
6 years, 2 months ago (2014-09-30 07:43:56 UTC) #3
verwaest1
I'm OOO for at least another week. Unless someone else can take a look, this'll ...
6 years, 2 months ago (2014-10-01 08:26:55 UTC) #5
Toon Verwaest
lgtm
6 years, 2 months ago (2014-10-15 11:16:49 UTC) #6
Toon Verwaest
Committed patchset #1 (id:1) manually as 24631 (presubmit successful).
6 years, 2 months ago (2014-10-15 12:36:05 UTC) #7
Toon Verwaest
5 years, 8 months ago (2015-04-24 18:51:07 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/588573002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/588573002/diff/1/src/hydrogen.cc#newcode8153
src/hydrogen.cc:8153: HConstant::cast(receiver)->handle(isolate()))->map());
This caused a major issue since no map-check is added for the map that's
introduced here. Array.prototype.push will happily push doubles on non-double
arrays.

Powered by Google App Engine
This is Rietveld 408576698