Let --js-flags work when Harmony is enabled in about:flags

Let --js-flags work when Harmony is enabled in about:flags

R=jochen@chromium.org
BUG=

Committed: https://crrev.com/727cae88098c3fd91df47afa64cb756b54050b20
Cr-Commit-Position: refs/heads/master@{#295960}

[Erik Corry, 2014-09-22 09:46:40]

erik.corry@gmail.com changed reviewers:
+ erik.corry@gmail.com

[Erik Corry, 2014-09-22 09:46:40]

At the moment, if you enable Harmony in about:flags, it stomps on any --js-flags
option that is passed to Chrome on the command line. This change fixes that by
adding a real command line flag for Chrome: --javascript-harmony.  By using this
flag when the user checks the box in about:flags we can avoid silently breaking
other uses of --js-flags.

[jochen (gone - plz use gerrit), 2014-09-22 09:49:18]

jochen@chromium.org changed reviewers:
- erik.corry@gmail.com

[jochen (gone - plz use gerrit), 2014-09-22 09:49:19]

https://codereview.chromium.org/588543003/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/588543003/diff/1/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:813:
SINGLE_VALUE_TYPE(switches::kJavaScriptHarmony)
the switch should be in chrome/common/chrome_switches.cc, copied to the renderer
in ChromeContentBrowserClient::AppendExtraCommandLineSwitches, and passed to v8
in ChromeRenderProcessObserver's ctor

[Erik Corry, 2014-09-22 13:18:47]

erik.corry@gmail.com changed reviewers:
+ erik.corry@gmail.com

[Erik Corry, 2014-09-22 13:18:47]

https://codereview.chromium.org/588543003/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/588543003/diff/1/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:813:
SINGLE_VALUE_TYPE(switches::kJavaScriptHarmony)
On 2014/09/22 09:49:19, jochen (slow for reviews) wrote:
> the switch should be in chrome/common/chrome_switches.cc, copied to the
renderer
> in ChromeContentBrowserClient::AppendExtraCommandLineSwitches, and passed to
v8
> in ChromeRenderProcessObserver's ctor 

Done.

[jochen (gone - plz use gerrit), 2014-09-22 13:36:34]

lgtm

[Erik Corry Chromium.org, 2014-09-22 13:50:27]

Committed patchset #2 (id:20001) manually as 727cae8 (presubmit successful).

[commit-bot: I haz the power, 2014-09-22 13:50:29]

Patchset 2 (id:??) landed as
https://crrev.com/727cae88098c3fd91df47afa64cb756b54050b20
Cr-Commit-Position: refs/heads/master@{#295960}

[Mathieu, 2014-09-22 14:37:54]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/589093003/ by mathp@chromium.org.

The reason for reverting is: Breaks unit_tests

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

[jam, 2014-09-22 15:56:46]

On 2014/09/22 14:37:54, Mathieu Perreault wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/589093003/ by mailto:mathp@chromium.org.
> 
> The reason for reverting is: Breaks unit_tests
> 
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

why did you commit this without running tests?