Add define required for VS2013 ATL to target XP

Add define required for VS2013 ATL to target XP

See linked bug for details.

TBR=cpu@chromium.org
BUG=297971
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234446

[commit-bot: I haz the power, 2013-11-12 04:36:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/58853015/20001

[commit-bot: I haz the power, 2013-11-12 07:13:38]

Change committed as 234446

[Sébastien Marchand, 2013-11-20 17:55:20]

It looks like we should use the v120_xp platform toolset (here for v110_xp, I
presume that it's the same for 120). Wouldn't it be safer (if we want to make
sure that no one break XP support) to use this target instead of using some
obscure flags ?

[Sébastien Marchand, 2013-11-20 17:56:56]

"...the supported versions are Windows XP SP3 for x86...", we officially support
XP SP2 :(

[scottmg, 2013-11-20 18:05:26]

On 2013/11/20 17:55:20, Sébastien Marchand wrote:
> It looks like we should use the v120_xp platform toolset (here for v110_xp, I
> presume that it's the same for 120). Wouldn't it be safer (if we want to make
> sure that no one break XP support) to use this target instead of using some
> obscure flags ?

"v120_xp" is an msbuild-ism isn't it? I don't think gyp/ninja understands or
converts any of that as it'd have to parse and understand the msbuild xml files.
If you know better though, it'd be great if you could sort it out.

I was going based on the VC blog
http://blogs.msdn.com/b/vcblog/archive/2012/10/08/10357555.aspx?PageIndex=3 so
it seems somewhat documented/supported.

[scottmg, 2013-11-20 18:07:53]

On 2013/11/20 17:56:56, Sébastien Marchand wrote:
> "...the supported versions are Windows XP SP3 for x86...", we officially
support
> XP SP2 :(

Dear god, why do we do that? I guess for XP x64, in theory?

[Sébastien Marchand, 2013-11-20 18:52:48]

I've no idea why the minimal supported version is SP2. It looks like the
_USING_V110_SDK71_ is mainly used on altwinverapi.h to avoid to call
InitializeCriticalSectionEx (which is Vista+) in
_AtlInitializeCriticalSectionEx.

Another way to fix this would be to define NTDDI_VERSION to NTDDI_WINXPSP2 but
it'll break the delayloads apparently... So this approach lgtm and I'll go as
far as using the same approach in Syzygy :)