Issue 58853009: Pepper: Add shared Utilities for file systems.

Issue 58853009: Pepper: Add shared Utilities for file systems. (Closed)

Created:
7 years, 1 month ago by bbudge

Modified:
7 years, 1 month ago

Reviewers:
dmichael (off chromium), ericu

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper: Add shared Utilities for file systems. Adds a function to convert Pepper file system types to fileapi equivalents. Adds a function to indicate if a file system needs quota checks. BUG=194304 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234599

Patch Set 1 #

Patch Set 2 : Add new files, tighten includes, modify DEPS. #

Patch Set 3 : Add IsValid function. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -34 lines)			Patch
M	content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc	View		2 chunks	+5 lines, -14 lines	0 comments	Download
M	content/renderer/pepper/pepper_file_io_host.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_file_system_host.cc	View		2 chunks	+5 lines, -14 lines	0 comments	Download
M	ppapi/ppapi_shared.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/proxy/file_io_resource.cc	View	1 2	2 chunks	+2 lines, -4 lines	0 comments	Download
M	ppapi/shared_impl/DEPS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	ppapi/shared_impl/file_system_util.h	View	1 2	1 chunk	+24 lines, -0 lines	0 comments	Download
A	ppapi/shared_impl/file_system_util.cc	View	1 2	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

Looks like you need to add file_system_util.* to the CL

7 years, 1 month ago (2013-11-08 23:38:03 UTC) #2

bbudge

Ready for another look. I added another utility function, PepperFileSystemIsValid. Really, the reason for this ...

7 years, 1 month ago (2013-11-11 18:12:12 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/58853009/160001

7 years, 1 month ago (2013-11-11 19:32:46 UTC) #6

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=35511

7 years, 1 month ago (2013-11-11 19:59:38 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/58853009/160001

7 years, 1 month ago (2013-11-12 16:56:35 UTC) #11

Message was sent while issue was closed.

Change committed as 234599

Expand Messages | Collapse Messages