[win8] Force browsers created with Chrome in Metro mode to be on the Ash desktop.

chrome/browser/ui/views/frame/native_browser_frame_factory.h

Index: chrome/browser/ui/views/frame/native_browser_frame_factory.h
diff --git a/chrome/browser/ui/views/frame/native_browser_frame_factory.h b/chrome/browser/ui/views/frame/native_browser_frame_factory.h
index 3441e08a2c024fed447f36d855fea61a13ca21c4..4921c507408bea3a7519db4c984685da1925357e 100644
--- a/chrome/browser/ui/views/frame/native_browser_frame_factory.h
+++ b/chrome/browser/ui/views/frame/native_browser_frame_factory.h
@@ -30,6 +30,11 @@ class NativeBrowserFrameFactory {
   NativeBrowserFrameFactory() {}
   virtual ~NativeBrowserFrameFactory() {}
 
+ private:
+  // For Chrome running on desktop platforms, returns true if the factory should
+  // create an ash browser frame for the provided |browser_view|.
+  static bool ShouldCreateForAshDesktop(BrowserView* browser_view);

[tapted, 2013/11/15 12:47:11]

Note: the current approach leaves this undefined on chromeos, and on use_ash==0.
Alternative is a header like native_browser_frame_factory_nonchromeosash.h or
_ashwinanddesktoplinux.h. Or an #ifdef here, but it's not strictly needed..

[sky, 2013/11/15 17:31:27]

Is there a reason not to move it to native_browser_frame_factory.cc and always
compile it?

[tapted, 2013/11/18 11:13:48]

It needs to pull in some ash-specific files - if that's OK I can merge the
definition from native_browser_frame_factory_desktop_ash.cc into
native_browser_frame_factory.cc. I've now added the missing definition there to
compare (Done.), but it is just NOTREACHED(). I kept the definition out
initially because, without it, the NOTREACHED can be a link error rather than a
runtime error (but maybe that's more confusing).

+
   DISALLOW_COPY_AND_ASSIGN(NativeBrowserFrameFactory);
 };