src/mips/code-stubs-mips.cc - Issue 58853003: MIPS: Try to use Push instead of push sequences whenever possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/code-stubs-mips.cc

Issue 58853003: MIPS: Try to use Push instead of push sequences whenever possible. (Closed) Base URL: https://github.com/v8/v8.git@gbl

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/code-stubs-mips.cc

diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc

index 0592f2e2a63ba12e641ef07b0d5386fc18099ce9..a0e990ccb06350a36ceafca6b2715252f2c15388 100644

--- a/src/mips/code-stubs-mips.cc

+++ b/src/mips/code-stubs-mips.cc

@@ -5156,8 +5156,7 @@ void ICCompareStub::GenerateMiss(MacroAssembler* masm) {

ExternalReference(IC_Utility(IC::kCompareIC_Miss), masm->isolate());

FrameScope scope(masm, StackFrame::INTERNAL);

__ Push(a1, a0);

- __ push(ra);

- __ Push(a1, a0);

+ __ Push(ra, a1, a0);

__ li(t0, Operand(Smi::FromInt(op_)));

__ addiu(sp, sp, -kPointerSize);

__ CallExternalReference(miss, 3, USE_DELAY_SLOT);

« no previous file with comments | « src/mips/builtins-mips.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »