Fix the way how we create webrtc::AudioProcessing in Chrome

Fix the way how we create webrtc::AudioProcessing in Chrome.

BUG=415935
TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist.

Committed: https://crrev.com/a5e9fc62b7bf25931ffe6153cc738098d8119c28
Cr-Commit-Position: refs/heads/master@{#295990}

[no longer working on chromium, 2014-09-19 12:10:01]

xians@chromium.org changed reviewers:
+ tommi@chromium.org

[no longer working on chromium, 2014-09-19 12:15:49]

Tommi, could you please review this CL?

Thanks,
SX

[tommi (sloooow) - chröme, 2014-09-19 12:48:19]

looks like you need to add a dependency to AudioProcessing to the
libpeerconnection target.

[tommi (sloooow) - chröme, 2014-09-19 14:21:23]

On 2014/09/19 12:48:19, tommi wrote:
> looks like you need to add a dependency to AudioProcessing to the
> libpeerconnection target.

oh and can you remove that dependency from the gyp file in content as well?
You may have to update gn files as well.

[no longer working on chromium, 2014-09-19 16:20:45]

Patchset #3 (id:40001) has been deleted

[no longer working on chromium, 2014-09-22 15:14:05]

Hi Tommi, I was not able to fix the typing detection in this CL, because there
is no static method to create the webrtc::TypingDetection, I need to make a
static method in webrtc CL, roll it to Chrome, then fix it in init_webrtc.cc.

Another alternative is that I can copy the
third_party/webrtc/modules/audio_processing/typing_detection.cc implementation
to Chrome, but not sure if will be easy to merge.

Could you please take a look at this version to see if I am doing the correct
things in init_webrtc.cc, especially when libpeerconnection is being compiled as
a static lib.


Thanks,
SX

[tommi (sloooow) - chröme, 2014-09-22 16:35:53]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2014-09-22 16:35:53]

lgtm

[commit-bot: I haz the power, 2014-09-22 16:36:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588523002/100001

[commit-bot: I haz the power, 2014-09-22 16:43:16]

Committed patchset #5 (id:100001) as bfcdb0f5795c680e8638489f55c586308b2c015d

[commit-bot: I haz the power, 2014-09-22 16:44:52]

Patchset 5 (id:??) landed as
https://crrev.com/a5e9fc62b7bf25931ffe6153cc738098d8119c28
Cr-Commit-Position: refs/heads/master@{#295990}

[no longer working on chromium, 2014-09-22 16:53:44]

On 2014/09/22 16:44:52, I haz the power (commit-bot) wrote:
> Patchset 5 (id:??) landed as
> https://crrev.com/a5e9fc62b7bf25931ffe6153cc738098d8119c28
> Cr-Commit-Position: refs/heads/master@{#295990}

Thanks Tommi.

[no longer working on chromium, 2014-09-23 15:31:23]

A revert of this CL (patchset #5 id:100001) has been created in
https://codereview.chromium.org/594883002/ by xians@chromium.org.

The reason for reverting is: It broke some internal webrtc bots, revert it for
now and will reland it after fixing the problems.

http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Mac%20Tes....