Chromium Code Reviews
Help | Chromium Project | Sign in
(151)

Issue 5885001: Revert 69237 - Fix raw_scoped_refptr_mismatch_checker.h.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Paweł Hajdan Jr.
Modified:
3 years, 10 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 69237 - Fix raw_scoped_refptr_mismatch_checker.h. BUG=28083 TEST=none Review URL: http://codereview.chromium.org/3549010 TBR=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -148 lines) Patch
M base/callback.h View 1 chunk +2 lines, -3 lines 0 comments Download
M base/raw_scoped_refptr_mismatch_checker.h View 1 chunk +130 lines, -89 lines 0 comments Download
M base/task.h View 3 chunks +6 lines, -9 lines 0 comments Download
M base/template_util.h View 2 chunks +0 lines, -47 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
4 years, 3 months ago (2010-12-15 08:32:44 UTC) #1
Paweł Hajdan Jr.
4 years, 3 months ago (2010-12-15 08:47:58 UTC) #2
willchan OOO until 04-22-15
4 years, 3 months ago (2010-12-15 08:48:04 UTC) #3
Thanks for the revert.  FYI, I have a fix and plan to reland tonight so more
regressions don't trickle in.

On Wed, Dec 15, 2010 at 12:32 AM, <phajdan.jr@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Revert 69237 - Fix raw_scoped_refptr_mismatch_checker.h.
>
> BUG=28083
> TEST=none
>
> Review URL: http://codereview.chromium.org/3549010
>
> TBR=willchan@chromium.org
>
> Please review this at http://codereview.chromium.org/5885001/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     base/callback.h
>  M     base/raw_scoped_refptr_mismatch_checker.h
>  M     base/task.h
>  M     base/template_util.h
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cf4c24d