Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Issue 588483002: GridPainter::paintChild should take RenderBox reference (Closed)

Created:
6 years, 3 months ago by Sunil Ratnu
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, rune+blink, svillar, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

GridPainter::paintChild should take RenderBox reference GridPainter method paintChild() take pointer to RenderBox instance but the body of this method assumes that the object will never be NULL. We should replace it to use RenderBox references. This somehow got missed in the previous revision of converting pointers to references. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182738

Patch Set 1 #

Patch Set 2 : Rebase to the latest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/core/paint/GridPainter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/GridPainter.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Sunil Ratnu
A minor change. Please review this. Thanks!
6 years, 3 months ago (2014-09-19 06:39:41 UTC) #2
Sunil Ratnu
On 2014/09/19 06:39:41, Sunil Ratnu wrote: > A minor change. Please review this. Thanks! Gentle ...
6 years, 3 months ago (2014-09-23 19:50:03 UTC) #3
mstensho (USE GERRIT)
RenderGrid painting code has just been moved to GridPainter [1], so you need to update ...
6 years, 2 months ago (2014-09-25 06:52:11 UTC) #5
Sunil Ratnu
On 2014/09/25 06:52:11, mstensho wrote: > RenderGrid painting code has just been moved to GridPainter ...
6 years, 2 months ago (2014-09-25 07:06:42 UTC) #6
esprehn
lgtm
6 years, 2 months ago (2014-09-26 04:00:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588483002/20001
6 years, 2 months ago (2014-09-26 05:03:08 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 06:53:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182738

Powered by Google App Engine
This is Rietveld 408576698