Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 588473003: Add DocumentExecCommandInJavaScript.js to Blink platform resources. (Closed)

Created:
6 years, 3 months ago by yosin_UTC9
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add DocumentExecCommandInJavaScript.js to Blink platform resources. This prepares for landing of http://crrev.com/530663002 which now requires a three-sided change due to changes in how Blink accesses private script resources. Part 1: http://crrev.com/583753003 BUG=408887 TEST=n/a; no code changes Committed: https://crrev.com/8bf3d4139bce38e8eb711c6d7a66744699859008 Cr-Commit-Position: refs/heads/master@{#297130}

Patch Set 1 : 2014-09-19T17:03:00 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/child/blink_platform_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yosin_UTC9
Could you review this patch, similar to http://crrev.com/556793006, which added PluginPlaceholderElement.js? Thanks in advance.
6 years, 2 months ago (2014-09-24 04:00:01 UTC) #3
yosin_UTC9
ping...
6 years, 2 months ago (2014-09-26 01:21:42 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-09-26 19:45:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588473003/20001
6 years, 2 months ago (2014-09-29 01:05:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001) as de4e340dda44cfaff1e2e422a2be458a5e372762
6 years, 2 months ago (2014-09-29 02:12:18 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 02:12:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bf3d4139bce38e8eb711c6d7a66744699859008
Cr-Commit-Position: refs/heads/master@{#297130}

Powered by Google App Engine
This is Rietveld 408576698