Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 588463002: chromium_build_stats: add favicon.ico and robots.txt (Closed)

Created:
6 years, 3 months ago by ukai
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Project:
infra
Visibility:
Public.

Description

chromium_build_stats: add favicon.ico and robots.txt Committed: https://chromium.googlesource.com/infra/infra/+/e68e5f0b14e903e268ce38b70eab7b0abc68ec5e

Patch Set 1 #

Total comments: 4

Patch Set 2 : quote dot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M appengine/chromium_build_stats/default/app.yaml View 1 1 chunk +10 lines, -0 lines 0 comments Download
A + appengine/chromium_build_stats/default/static/favicon.ico View Binary file 0 comments Download
A appengine/chromium_build_stats/default/static/robots.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ukai
6 years, 3 months ago (2014-09-19 05:29:00 UTC) #2
shinyak
lgtm https://codereview.chromium.org/588463002/diff/1/appengine/chromium_build_stats/default/app.yaml File appengine/chromium_build_stats/default/app.yaml (right): https://codereview.chromium.org/588463002/diff/1/appengine/chromium_build_stats/default/app.yaml#newcode18 appengine/chromium_build_stats/default/app.yaml:18: - url: /(.+.ico) Maybe /(.+\.ico) ? https://codereview.chromium.org/588463002/diff/1/appengine/chromium_build_stats/default/app.yaml#newcode21 appengine/chromium_build_stats/default/app.yaml:21: ...
6 years, 3 months ago (2014-09-19 05:40:04 UTC) #3
ukai
https://codereview.chromium.org/588463002/diff/1/appengine/chromium_build_stats/default/app.yaml File appengine/chromium_build_stats/default/app.yaml (right): https://codereview.chromium.org/588463002/diff/1/appengine/chromium_build_stats/default/app.yaml#newcode18 appengine/chromium_build_stats/default/app.yaml:18: - url: /(.+.ico) On 2014/09/19 05:40:04, shinyak wrote: > ...
6 years, 3 months ago (2014-09-19 06:19:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588463002/20001
6 years, 3 months ago (2014-09-24 08:09:54 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 08:11:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as e68e5f0b14e903e268ce38b70eab7b0abc68ec5e

Powered by Google App Engine
This is Rietveld 408576698