Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: extensions/browser/api/cast_channel/logger_util.h

Issue 588433002: Revert "Make protobuf enums canonical for ReadState/WriteState/ConnectState." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/cast_channel/logger_util.h
diff --git a/extensions/browser/api/cast_channel/logger_util.h b/extensions/browser/api/cast_channel/logger_util.h
index 499b1e55ddc8cf1524eb58a2ac4cd63f76701413..b00e8fcca166aadfaedbc46e9ede4cfd26a86ee2 100644
--- a/extensions/browser/api/cast_channel/logger_util.h
+++ b/extensions/browser/api/cast_channel/logger_util.h
@@ -6,16 +6,13 @@
#define EXTENSIONS_BROWSER_API_CAST_CHANNEL_LOGGER_UTIL_H_
#include "extensions/browser/api/cast_channel/logging.pb.h"
-#include "extensions/common/api/cast_channel.h"
namespace extensions {
namespace core_api {
namespace cast_channel {
-// Converts an IDL "ChannelError" to a proto enum "ErrorState".
-proto::ErrorState ErrorStateToProto(ChannelError state);
-// Converts an IDL "ReadyState" to a proto enum "ReadyState".
-proto::ReadyState ReadyStateToProto(ReadyState state);
+// TODO(mfoltz): Move the *ToProto functions from cast_socket.cc here.
+// CastSocket should not need to know details of the logging protocol message.
// Holds the most recent errors encountered by a CastSocket.
struct LastErrors {
« no previous file with comments | « extensions/browser/api/cast_channel/cast_socket.cc ('k') | extensions/browser/api/cast_channel/logger_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698