Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 588433002: Revert "Make protobuf enums canonical for ReadState/WriteState/ConnectState." (Closed)

Created:
6 years, 3 months ago by Elliot Glaysher
Modified:
6 years, 3 months ago
Reviewers:
Kevin M
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Make protobuf enums canonical for ReadState/WriteState/ConnectState." This reverts commit f1624ddce4b88a5a950f65b511677b914c9caefb. Broke Google Chrome ChromeOS compile: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/72048/steps/compile/logs/stdio In file included from gen/extensions/browser/api/generated_api_registration.cc:20: In file included from ../../extensions/browser/api/cast_channel/cast_channel_api.h:16: ../../extensions/browser/api/cast_channel/cast_socket.h:19:10: fatal error: 'extensions/browser/api/cast_channel/logging.pb.h' file not found ^ (Manually reverted because of file add.) TBR=kmarshall@chromium.org BUG= Committed: https://chromium.googlesource.com/chromium/src/+/4b10ffbe3ef9bcc9a1007ae12b7ef7c71db6022b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -400 lines) Patch
M extensions/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/api_registration.gyp View 1 chunk +0 lines, -1 line 0 comments Download
A + extensions/browser/api/cast_channel/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/cast_channel/cast_channel.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_socket.h View 4 chunks +36 lines, -7 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_socket.cc View 25 chunks +184 lines, -70 lines 0 comments Download
M extensions/browser/api/cast_channel/logger_util.h View 1 chunk +2 lines, -5 lines 0 comments Download
M extensions/browser/api/cast_channel/logger_util.cc View 2 chunks +1 line, -46 lines 0 comments Download
A + extensions/browser/api/cast_channel/logging.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/common/api/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/api/api.gyp View 1 chunk +0 lines, -15 lines 0 comments Download
D extensions/common/api/cast_channel/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D extensions/common/api/cast_channel/cast_channel.proto View 1 chunk +0 lines, -91 lines 0 comments Download
D extensions/common/api/cast_channel/logging.proto View 1 chunk +0 lines, -149 lines 0 comments Download
M extensions/extensions.gyp View 3 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4b10ffbe3ef9bcc9a1007ae12b7ef7c71db6022b Cr-Commit-Position: refs/heads/master@{#295611}
6 years, 3 months ago (2014-09-18 23:59:57 UTC) #1
Elliot Glaysher
6 years, 3 months ago (2014-09-19 00:00:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 4b10ffb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698