[VS Addin] Cleanup create_package.py

[VS Addin]  Cleanup create_package.py

Seperate staging of resource from creating archive.
This makes it far clearer what exactly ends up on the
final archive (i.e. the exact contents of the staging
folder).

TEST=verify resulting archive has same contents.
R=binji@chromium.org

Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1577

[Sam Clegg, 2014-09-23 01:08:06]

sbc@chromium.org changed reviewers:
+ binji@chromium.org

[binji, 2014-09-23 20:37:35]

lgtm

https://codereview.chromium.org/588423002/diff/20001/visual_studio/NativeClie...
File visual_studio/NativeClientVSAddIn/create_package.py (right):

https://codereview.chromium.org/588423002/diff/20001/visual_studio/NativeClie...
visual_studio/NativeClientVSAddIn/create_package.py:84: def
StageDirectory(dir_to_copy):
this seems to be mostly copy/paste from AddFolderToArchive below. Any way to
combine them?

https://codereview.chromium.org/588423002/diff/20001/visual_studio/NativeClie...
visual_studio/NativeClientVSAddIn/create_package.py:101: relative_dir =
root[len(dir_to_copy):]
I usually use os.path.relpath for this

[Sam Clegg, 2014-09-24 17:24:42]

ptal.

https://codereview.chromium.org/588423002/diff/20001/visual_studio/NativeClie...
File visual_studio/NativeClientVSAddIn/create_package.py (right):

https://codereview.chromium.org/588423002/diff/20001/visual_studio/NativeClie...
visual_studio/NativeClientVSAddIn/create_package.py:84: def
StageDirectory(dir_to_copy):
On 2014/09/23 20:37:35, binji wrote:
> this seems to be mostly copy/paste from AddFolderToArchive below. Any way to
> combine them?

Cleaned these up.

https://codereview.chromium.org/588423002/diff/20001/visual_studio/NativeClie...
visual_studio/NativeClientVSAddIn/create_package.py:101: relative_dir =
root[len(dir_to_copy):]
On 2014/09/23 20:37:35, binji wrote:
> I usually use os.path.relpath for this

Done. Thanks.

[binji, 2014-09-24 17:41:58]

slgtm

https://codereview.chromium.org/588423002/diff/40001/visual_studio/NativeClie...
File visual_studio/NativeClientVSAddIn/create_package.py (right):

https://codereview.chromium.org/588423002/diff/40001/visual_studio/NativeClie...
visual_studio/NativeClientVSAddIn/create_package.py:110: """Recursively adds a
direcotry to an open archive object.
sp: directory (below too)

[Sam Clegg, 2014-09-24 17:52:18]

Committed patchset #4 manually as r1577 (presubmit successful).