Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 588403003: Fix a rendering bug when frames have no dirty rect on display list mode. (Closed)

Created:
6 years, 3 months ago by zino
Modified:
6 years, 3 months ago
Reviewers:
Sergey, Justin Novosad
CC:
blink-reviews, jamesr, pdr+graphicswatchlist_chromium.org, jbroman, mkwst+moarreviews_chromium.org, danakj, Rik, Stephen Chennney, krit, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix a rendering bug when frames have no dirty rect on display list mode. In the current implementation, finalizeFrameInternal() is returned early when the image buffer doesn't have dirty rect. Even so we should transfer a state stack to next canvas. BUG=392614 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182556

Patch Set 1 #

Patch Set 2 : remove js-test.js #

Total comments: 1

Patch Set 3 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -10 lines) Patch
A LayoutTests/fast/canvas/canvas-state-persistence-no-dirty.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-state-persistence-no-dirty-expected.html View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurface.cpp View 3 chunks +16 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
zino
Please take a look. Thank you.
6 years, 3 months ago (2014-09-23 11:07:19 UTC) #2
Justin Novosad
This logic seems reasonable to me. Sergey, what do you think? lgtm with minor comment ...
6 years, 3 months ago (2014-09-23 15:09:52 UTC) #4
Sergey
On 2014/09/23 15:09:52, junov wrote: > This logic seems reasonable to me. Sergey, what do ...
6 years, 3 months ago (2014-09-24 01:55:28 UTC) #5
zino
On 2014/09/24 01:55:28, Sergey wrote: > On 2014/09/23 15:09:52, junov wrote: > > This logic ...
6 years, 3 months ago (2014-09-24 02:01:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588403003/40001
6 years, 3 months ago (2014-09-24 02:01:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/28476)
6 years, 3 months ago (2014-09-24 04:16:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588403003/40001
6 years, 3 months ago (2014-09-24 05:02:49 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 05:41:53 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 182556

Powered by Google App Engine
This is Rietveld 408576698