Mac: Fix tab view accessibility.

Mac: Fix tab view accessibility.

The close button was setting the AXDescription property, it somehow caused
VoiceOver to use it as the tab view's description. Change it to set the AXTitle
property instead to fix the issue, and to match Safari.

Also change the tab strips' AX children to be sorted from left to right, so
that VoiceOver's "Tab X of Y" order is always ascending left to right.

BUG=415570
Committed: https://crrev.com/1ccf1740236df20591e4cf5150d3a296faa0efb3
Cr-Commit-Position: refs/heads/master@{#296346}

[Andre, 2014-09-22 23:41:07]

andresantoso@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[Andre, 2014-09-22 23:41:07]

Domic PTAL.

[dmazzoni, 2014-09-23 05:50:24]

lgtm

[Andre, 2014-09-23 17:16:26]

andresantoso@chromium.org changed reviewers:
+ avi@chromium.org

[Andre, 2014-09-23 17:16:27]

Avi, please review.

[Avi (use Gerrit), 2014-09-23 20:44:21]

LGTM either way.

https://codereview.chromium.org/588393002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/tabs/tab_strip_view.mm (right):

https://codereview.chromium.org/588393002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tabs/tab_strip_view.mm:233: [super
accessibilityAttributeValue:NSAccessibilityChildrenAttribute];
Oh, yikes, was it really returning them in Z order? :(

https://codereview.chromium.org/588393002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tabs/tab_strip_view.mm:265: return tabs;
If you're already introducing blocks code, you could do

NSIndexSet* indexes = [children indexesOfObjectsPassingTest:^(...){ return
attribute isEqual:buttonRole}];
return [children objectsAtIndexes:indexes];

which is a bit cleaner.

[Andre, 2014-09-23 21:41:55]

https://codereview.chromium.org/588393002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/tabs/tab_strip_view.mm (right):

https://codereview.chromium.org/588393002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tabs/tab_strip_view.mm:265: return tabs;
On 2014/09/23 20:44:20, Avi wrote:
> If you're already introducing blocks code, you could do
> 
> NSIndexSet* indexes = [children indexesOfObjectsPassingTest:^(...){ return
> attribute isEqual:buttonRole}];
> return [children objectsAtIndexes:indexes];
> 
> which is a bit cleaner.

Done.
I love programming with higher order functions in place of loops.
In my previous job, I made utilities to make these things even neater.
Something like:
  return Filter(children, ^BOOL(id child) {
      ...
  });

In this case, it would have reduced #lines by 4 instead of by 2.

The filter function takes id<NSFastEnumeration> as argument, so it works with
arrays, sets and dictionaries.
Same with Map, Reduce, Reject, Find, Any.
Maybe we can add these to chromium someday?
I look forward to the day I can program in Swift :-D

[Avi (use Gerrit), 2014-09-23 23:24:54]

https://codereview.chromium.org/588393002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/tabs/tab_strip_view.mm (right):

https://codereview.chromium.org/588393002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tabs/tab_strip_view.mm:265: return tabs;
On 2014/09/23 21:41:55, Andre wrote:
> On 2014/09/23 20:44:20, Avi wrote:
> > If you're already introducing blocks code, you could do
> > 
> > NSIndexSet* indexes = [children indexesOfObjectsPassingTest:^(...){ return
> > attribute isEqual:buttonRole}];
> > return [children objectsAtIndexes:indexes];
> > 
> > which is a bit cleaner.
> 
> Done.
> I love programming with higher order functions in place of loops.
> In my previous job, I made utilities to make these things even neater.
> Something like:
>   return Filter(children, ^BOOL(id child) {
>       ...
>   });
> 
> In this case, it would have reduced #lines by 4 instead of by 2.
> 
> The filter function takes id<NSFastEnumeration> as argument, so it works with
> arrays, sets and dictionaries.
> Same with Map, Reduce, Reject, Find, Any.
> Maybe we can add these to chromium someday?
> I look forward to the day I can program in Swift :-D

I was honestly shocked that Apple didn't already have a block equivalent to
-[NSArray filteredArrayUsingPredicate:]...

[Andre, 2014-09-23 23:26:44]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2014-09-23 23:28:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588393002/40001

[commit-bot: I haz the power, 2014-09-24 00:01:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-24 00:01:42]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Andre, 2014-09-24 00:39:35]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2014-09-24 00:40:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588393002/40001

[commit-bot: I haz the power, 2014-09-24 00:44:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-24 00:44:20]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Andre, 2014-09-24 04:41:26]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2014-09-24 04:42:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588393002/40001

[commit-bot: I haz the power, 2014-09-24 04:43:04]

Committed patchset #3 (id:40001) as 625536578e07927e7bde01147fed466962d060e9

[commit-bot: I haz the power, 2014-09-24 04:43:38]

Patchset 3 (id:??) landed as
https://crrev.com/1ccf1740236df20591e4cf5150d3a296faa0efb3
Cr-Commit-Position: refs/heads/master@{#296346}