ipc/ipc_channel_win.h - Issue 588383003: IPC: Use ScopedHandle instead of a raw HANDLE for the private members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_win.h

Issue 588383003: IPC: Use ScopedHandle instead of a raw HANDLE for the private members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_channel_win.h

diff --git a/ipc/ipc_channel_win.h b/ipc/ipc_channel_win.h

index dd341a776f5a0bf2c87a27962b086b87317a434c..52446500bfc2aba8a152b07622d2f1eb6fb86e3d 100644

--- a/ipc/ipc_channel_win.h

+++ b/ipc/ipc_channel_win.h

@@ -13,6 +13,7 @@

#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "base/message_loop/message_loop.h"

+#include "base/win/scoped_handle.h"

#include "ipc/ipc_channel_reader.h"

namespace base {

@@ -74,7 +75,7 @@ class ChannelWin : public Channel,

State input_state_;

State output_state_;

- HANDLE pipe_;

+ base::win::ScopedHandle pipe_;

base::ProcessId peer_pid_;

« no previous file with comments | « no previous file | ipc/ipc_channel_win.cc » ('j') | ipc/ipc_channel_win.cc » ('J')