Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 588383003: IPC: Use ScopedHandle instead of a raw HANDLE for the private members. (Closed)

Created:
6 years, 3 months ago by rvargas (doing something else)
Modified:
6 years, 2 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

IPC: Use ScopedHandle instead of a raw HANDLE for the private members. BUG=387876 R=cpu@chromium.org Committed: https://crrev.com/8c2d75c0c7f873096d9c6948338dd8a237c3edb7 Cr-Commit-Position: refs/heads/master@{#297011}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -39 lines) Patch
M ipc/ipc_channel_win.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M ipc/ipc_channel_win.cc View 1 12 chunks +40 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
rvargas (doing something else)
6 years, 3 months ago (2014-09-22 23:33:18 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/588383003/diff/1/ipc/ipc_channel_win.cc File ipc/ipc_channel_win.cc (right): https://codereview.chromium.org/588383003/diff/1/ipc/ipc_channel_win.cc#newcode143 ipc/ipc_channel_win.cc:143: morita has a lgtmed change here. https://codereview.chromium.org/588383003/diff/1/ipc/ipc_channel_win.cc#newcode255 ipc/ipc_channel_win.cc:255: ...
6 years, 2 months ago (2014-09-25 23:07:27 UTC) #2
rvargas (doing something else)
thanks https://codereview.chromium.org/588383003/diff/1/ipc/ipc_channel_win.cc File ipc/ipc_channel_win.cc (right): https://codereview.chromium.org/588383003/diff/1/ipc/ipc_channel_win.cc#newcode143 ipc/ipc_channel_win.cc:143: On 2014/09/25 23:07:27, cpu wrote: > morita has ...
6 years, 2 months ago (2014-09-25 23:26:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588383003/20001
6 years, 2 months ago (2014-09-26 18:44:14 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ff8c7991002880b338e86b645a637a7f3b159298
6 years, 2 months ago (2014-09-26 19:50:35 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 19:51:20 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c2d75c0c7f873096d9c6948338dd8a237c3edb7
Cr-Commit-Position: refs/heads/master@{#297011}

Powered by Google App Engine
This is Rietveld 408576698