Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 588383002: Service Workers: InstallPhaseEvent -> ExtendableEvent (Closed)

Created:
6 years, 3 months ago by jsbell
Modified:
6 years, 3 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, mkwst+moarreviews_chromium.org, falken, kinuko+serviceworker, horo+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Service Workers: InstallPhaseEvent -> ExtendableEvent The concept of an event that you can call waitUntil() on to delay the default behavior until the passed Promise resolves was made a more generic concept in the spec[1], and renamed so it can be used in other specs in the future. [1] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#extendable-event-interface BUG=413662 R=dominicc@chromium.org,tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182538

Patch Set 1 #

Patch Set 2 : Restore/rename test file #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -428 lines) Patch
M LayoutTests/FlakyTests View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/TestExpectations View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/serviceworker/extendable-event-waituntil.html View 4 chunks +4 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/install-phase-event-waituntil.html View 1 chunk +0 lines, -132 lines 0 comments Download
A + LayoutTests/http/tests/serviceworker/resources/extendable-event-waituntil.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/resources/install-phase-event-waituntil.js View 1 chunk +0 lines, -75 lines 0 comments Download
M Source/modules/modules.gypi View 4 chunks +4 lines, -4 lines 0 comments Download
A + Source/modules/serviceworkers/ExtendableEvent.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + Source/modules/serviceworkers/ExtendableEvent.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
A + Source/modules/serviceworkers/ExtendableEvent.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/InstallEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/InstallEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/InstallEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
D Source/modules/serviceworkers/InstallPhaseEvent.h View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/modules/serviceworkers/InstallPhaseEvent.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
D Source/modules/serviceworkers/InstallPhaseEvent.idl View 1 chunk +0 lines, -37 lines 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jsbell
Just a rename to match the spec. PTAL? CQ if it looks good?
6 years, 3 months ago (2014-09-22 23:26:23 UTC) #1
Michael van Ouwerkerk
On 2014/09/22 23:26:23, jsbell wrote: > Just a rename to match the spec. > > ...
6 years, 3 months ago (2014-09-23 08:46:54 UTC) #2
jsbell
Ugh, sorry folks - looks like I did a 'mv' instead of a 'git mv' ...
6 years, 3 months ago (2014-09-23 16:28:51 UTC) #3
tkent
lgtm
6 years, 3 months ago (2014-09-23 23:47:55 UTC) #5
jsbell
Okay, that looks better. R? CQ? (I think I can probably tbr someone for the ...
6 years, 3 months ago (2014-09-23 23:48:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588383002/40001
6 years, 3 months ago (2014-09-23 23:49:29 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 01:23:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 182538

Powered by Google App Engine
This is Rietveld 408576698