Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2852)

Unified Diff: chrome/browser/metrics/thread_watcher.cc

Issue 588373002: Increase ThreadWatcher unresponsive threashold to 72 secs in dev (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/thread_watcher.cc
diff --git a/chrome/browser/metrics/thread_watcher.cc b/chrome/browser/metrics/thread_watcher.cc
index 2f6d11bdf44566b0b1c60c7df0b34896967b990d..5dc540637fab23f522b7dfaa941e3ec917e73be4 100644
--- a/chrome/browser/metrics/thread_watcher.cc
+++ b/chrome/browser/metrics/thread_watcher.cc
@@ -534,7 +534,9 @@ void ThreadWatcherList::ParseCommandLine(
uint32* unresponsive_threshold,
CrashOnHangThreadMap* crash_on_hang_threads) {
// Initialize |unresponsive_threshold| to a default value.
- *unresponsive_threshold = kUnresponsiveCount;
+ // TODO(rtenneti): Changed the default value to 4 times, until we can triage
+ // hangs automatically (and to reduce the crash dumps).
+ *unresponsive_threshold = kUnresponsiveCount * 4;
// Increase the unresponsive_threshold on the Stable and Beta channels to
// reduce the number of crashes due to ThreadWatcher.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698