Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 588373002: Increase ThreadWatcher unresponsive threashold to 72 secs in dev (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org, rvargas (doing something else), Will Harris, ivanpe, karen, amineer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Increase ThreadWatcher unresponsive threashold to 72 secs in Dev Increase the #of pings from 9 to 36 for Dev (72 secs of unresponsiveness). Increased it to reduce the number of crash dump reports we receive. Will revert back, when we can auto triage jank on UI/IO threads. BUG=352489 R=sky@chromium.org Committed: https://crrev.com/64792b2912f3be895944800859042103f1ffd6b6 Cr-Commit-Position: refs/heads/master@{#296268}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/metrics/thread_watcher.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ramant (doing other things)
Hi Sky, We are getting thousands of crash reports. Until we fix crash system to ...
6 years, 3 months ago (2014-09-23 00:12:10 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-23 03:01:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588373002/20001
6 years, 3 months ago (2014-09-23 20:31:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:20001) as e4e909150689e3f05ef441d70f3f23c998e88176
6 years, 3 months ago (2014-09-23 21:54:10 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/64792b2912f3be895944800859042103f1ffd6b6 Cr-Commit-Position: refs/heads/master@{#296268}
6 years, 3 months ago (2014-09-23 21:54:48 UTC) #7
ramant (doing other things)
6 years ago (2014-12-09 02:34:16 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/783423002/ by rtenneti@chromium.org.

The reason for reverting is: chromecrash calculates the correct magic signature
for jank/hangs on UI/IO/FILE threads. Reverting this change to get crash dumps
if UI/IO/FILE threads don't respond for 9 pings (in 18 secs)..

Powered by Google App Engine
This is Rietveld 408576698