WebUI: Update some more uses of the old-style i18ntemplate/LocalStrings.

WebUI: Update some more uses of the old-style i18ntemplate/LocalStrings.

See [1] for network_menu.js/css deletion
See [2] for sim_unlock_ui.cc change

[1] https://codereview.chromium.org/6693032
[2] https://codereview.chromium.org/399303003/diff/100001/chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc#oldcode298

BUG=122753
Committed: https://crrev.com/b8489fb27b16f41dd7acdf8f2a331050789242dc
Cr-Commit-Position: refs/heads/master@{#296300}

[Evan Stade, 2014-09-23 00:05:19]

estade@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2014-09-23 00:20:48]

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/about_sys/about_sys.js (right):

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
chrome/browser/resources/about_sys/about_sys.js:171: var templateData = {
'details': details };
{\s -> {
\s} -> }

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
chrome/browser/resources/about_sys/about_sys.js:180: jstProcess(new
JsEvalContext(loadTimeData.data_), $('t'));
why is this accessing a private member?

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/chromeos/sim_unlock.js (right):

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/sim_unlock.js:63: 'enterPinTriesMessage',
tries);
unwrap

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/sim_unlock.js:116: 'enterPukWarning', tries);
unwrap

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
(right):

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js:57:
* Equivalent to loadTimeData.getString(id).
just remove this part of the comment, imo (it's pretty apparent in the
implementation)

https://codereview.chromium.org/588363002/diff/40001/chrome/test/data/webui/l...
File chrome/test/data/webui/local_strings_test.html (left):

https://codereview.chromium.org/588363002/diff/40001/chrome/test/data/webui/l...
chrome/test/data/webui/local_strings_test.html:10: var localStrings = new
LocalStrings;
is there such a test file for loadTimeData?

[Evan Stade, 2014-09-23 01:05:37]

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/about_sys/about_sys.js (right):

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
chrome/browser/resources/about_sys/about_sys.js:171: var templateData = {
'details': details };
On 2014/09/23 00:20:47, Dan Beam wrote:
> {\s -> {
> \s} -> }

Done.

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
chrome/browser/resources/about_sys/about_sys.js:180: jstProcess(new
JsEvalContext(loadTimeData.data_), $('t'));
On 2014/09/23 00:20:47, Dan Beam wrote:
> why is this accessing a private member?

fixed

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/chromeos/sim_unlock.js (right):

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/sim_unlock.js:63: 'enterPinTriesMessage',
tries);
On 2014/09/23 00:20:47, Dan Beam wrote:
> unwrap

Done.

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/sim_unlock.js:116: 'enterPukWarning', tries);
On 2014/09/23 00:20:47, Dan Beam wrote:
> unwrap

Done.

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
(right):

https://codereview.chromium.org/588363002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js:57:
* Equivalent to loadTimeData.getString(id).
On 2014/09/23 00:20:47, Dan Beam wrote:
> just remove this part of the comment, imo (it's pretty apparent in the
> implementation)

Done.

https://codereview.chromium.org/588363002/diff/40001/chrome/test/data/webui/l...
File chrome/test/data/webui/local_strings_test.html (left):

https://codereview.chromium.org/588363002/diff/40001/chrome/test/data/webui/l...
chrome/test/data/webui/local_strings_test.html:10: var localStrings = new
LocalStrings;
On 2014/09/23 00:20:47, Dan Beam wrote:
> is there such a test file for loadTimeData?

doubt it

[Dan Beam, 2014-09-23 05:30:39]

this breaks typechecking (as JsEvalContext isn't a known type in this file) but
I'll figure out a fix.

https://codereview.chromium.org/588363002/diff/100001/ui/webui/resources/js/l...
File ui/webui/resources/js/load_time_data.js (right):

https://codereview.chromium.org/588363002/diff/100001/ui/webui/resources/js/l...
ui/webui/resources/js/load_time_data.js:39: * Returns a JsEvalContext for
|data_|.
@returns {JsEvalContext}

https://codereview.chromium.org/588363002/diff/100001/ui/webui/resources/js/l...
ui/webui/resources/js/load_time_data.js:41: getJsEvalContext: function() {
nit: createJsEvalContext

[Dan Beam, 2014-09-23 05:30:46]

lgtm

[Evan Stade, 2014-09-23 17:34:58]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2014-09-23 17:35:08]

https://codereview.chromium.org/588363002/diff/100001/ui/webui/resources/js/l...
File ui/webui/resources/js/load_time_data.js (right):

https://codereview.chromium.org/588363002/diff/100001/ui/webui/resources/js/l...
ui/webui/resources/js/load_time_data.js:39: * Returns a JsEvalContext for
|data_|.
On 2014/09/23 05:30:39, Dan Beam wrote:
> @returns {JsEvalContext}

Done.

https://codereview.chromium.org/588363002/diff/100001/ui/webui/resources/js/l...
ui/webui/resources/js/load_time_data.js:41: getJsEvalContext: function() {
On 2014/09/23 05:30:39, Dan Beam wrote:
> nit: createJsEvalContext

Done.

[commit-bot: I haz the power, 2014-09-23 17:59:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588363002/120001

[Evan Stade, 2014-09-23 20:38:34]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2014-09-23 21:02:49]

estade@chromium.org changed reviewers:
+ alemate@chromium.org

[Evan Stade, 2014-09-23 21:02:50]

+alemate for merge_session_load_page.cc

[Alexander Alekseev, 2014-09-23 21:39:09]

lgtm

nkostylev, dzhioev: FYI

[Evan Stade, 2014-09-23 22:01:48]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-09-23 22:03:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588363002/140001

[commit-bot: I haz the power, 2014-09-23 23:38:11]

Committed patchset #8 (id:140001) as e32ba6ff030ea827762f7d3e9cc9f698f51a563d

[commit-bot: I haz the power, 2014-09-23 23:38:49]

Patchset 8 (id:??) landed as
https://crrev.com/b8489fb27b16f41dd7acdf8f2a331050789242dc
Cr-Commit-Position: refs/heads/master@{#296300}