Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 588333002: remove CountryAdapterAndroid (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
Ted C, aruslan
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove CountryAdapterAndroid it's not necessary now that we're using the libaddressinput widget. BUG=399146 Committed: https://crrev.com/d64a4dd2d96d7d1246a12017273e69be5b70d3b8 Cr-Commit-Position: refs/heads/master@{#296069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -222 lines) Patch
D chrome/android/java/src/org/chromium/chrome/browser/autofill/CountryAdapter.java View 1 chunk +0 lines, -124 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/ui/android/autofill/country_adapter_android.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/ui/android/autofill/country_adapter_android.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Evan Stade
6 years, 3 months ago (2014-09-22 21:06:18 UTC) #2
aruslan
happy to see it go, lgtm assuming it compiles etc.
6 years, 3 months ago (2014-09-22 21:07:48 UTC) #3
aruslan
On 2014/09/22 21:07:48, aruslan wrote: > happy to see it go, lgtm assuming it compiles ...
6 years, 3 months ago (2014-09-22 21:09:17 UTC) #4
Evan Stade
+tedchoc for jni_registrar
6 years, 3 months ago (2014-09-22 21:12:28 UTC) #6
Ted C
On 2014/09/22 21:12:28, Evan Stade wrote: > +tedchoc for jni_registrar lgtm
6 years, 3 months ago (2014-09-22 21:14:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588333002/1
6 years, 3 months ago (2014-09-22 21:16:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 82e73269040b7e2e095eaf517e05623c0dadeeed
6 years, 3 months ago (2014-09-22 22:21:27 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 22:22:08 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d64a4dd2d96d7d1246a12017273e69be5b70d3b8
Cr-Commit-Position: refs/heads/master@{#296069}

Powered by Google App Engine
This is Rietveld 408576698