Issue 58833006: net_ocsp: Explicitly ignore result of CalledOnValidThread().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 58833006: net_ocsp: Explicitly ignore result of CalledOnValidThread(). (Closed)

Created:
7 years, 1 month ago by Nico

Modified:
7 years, 1 month ago

Reviewers:
Ryan Sleevi, blundell

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

net_ocsp: Explicitly ignore result of CalledOnValidThread(). BUG=314505 R=blundell@chromium.org TBR=rsleevi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233169

Patch Set 3 : . #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	net/ocsp/nss_ocsp.cc	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blundell

LGTM, thanks. https://codereview.chromium.org/58833006/diff/40001/net/ocsp/nss_ocsp.cc File net/ocsp/nss_ocsp.cc (right): https://codereview.chromium.org/58833006/diff/40001/net/ocsp/nss_ocsp.cc#newcode92 net/ocsp/nss_ocsp.cc:92: // CalledOnValidThread is the only available api ...

7 years, 1 month ago (2013-11-05 16:35:06 UTC) #2

Nico

+rsleevi for owners https://codereview.chromium.org/58833006/diff/40001/net/ocsp/nss_ocsp.cc File net/ocsp/nss_ocsp.cc (right): https://codereview.chromium.org/58833006/diff/40001/net/ocsp/nss_ocsp.cc#newcode92 net/ocsp/nss_ocsp.cc:92: // CalledOnValidThread is the only available ...

7 years, 1 month ago (2013-11-05 16:37:28 UTC) #3

Nico

Committed patchset #3 manually as r233169 (presubmit successful).

7 years, 1 month ago (2013-11-06 01:11:26 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages

Issue 58833006: net_ocsp: Explicitly ignore result of CalledOnValidThread(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : err #

Patch Set 3 : . #

Messages