Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 588293002: Update chrome os light bar location (Closed)

Created:
6 years, 3 months ago by Chirantan Ekbote
Modified:
6 years, 3 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, Sameer Nanda, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update chrome os light bar location Recent modifications to the kernel have changed the location of the sysfs entry that controls the light bar. Update the light bar class with the new location. BUG=none Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>; Committed: https://crrev.com/2dd86aa7c9a5d5fb5b94d48413ba20b409dfc99a Cr-Commit-Position: refs/heads/master@{#296059}

Patch Set 1 #

Patch Set 2 : update file_util include #

Patch Set 3 : file_util include was already fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/chromeos/power/light_bar.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Chirantan Ekbote
please take a look
6 years, 3 months ago (2014-09-22 19:54:51 UTC) #2
Daniel Erat
lgtm
6 years, 3 months ago (2014-09-22 20:00:12 UTC) #3
Lei Zhang
On 2014/09/22 19:54:51, chirantan wrote: > please take a look I already mass updated them.
6 years, 3 months ago (2014-09-22 20:45:11 UTC) #4
Chirantan Ekbote
On 2014/09/22 at 20:45:11, thestig wrote: > On 2014/09/22 19:54:51, chirantan wrote: > > please ...
6 years, 3 months ago (2014-09-22 20:52:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588293002/40001
6 years, 3 months ago (2014-09-22 20:55:33 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as d8ac4adbb7ab3db7641e6a08b6967e06061b3260
6 years, 3 months ago (2014-09-22 21:57:23 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 21:58:05 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2dd86aa7c9a5d5fb5b94d48413ba20b409dfc99a
Cr-Commit-Position: refs/heads/master@{#296059}

Powered by Google App Engine
This is Rietveld 408576698