Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 588243002: Reland of "Remove void** from disk_cache interface" w/ blockfile iter fix. (Closed)

Created:
6 years, 3 months ago by gavinp
Modified:
6 years, 3 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, cbentzel+watch_chromium.org, serviceworker-reviews, gavinp+disk_chromium.org, tzik, horo+watch_chromium.org, jam, nhiroki, darin-cc_chromium.org, piman+watch_chromium.org, kinuko+serviceworker
Base URL:
https://chromium.googlesource.com/chromium/src.git@1-webcacheimpl
Project:
chromium
Visibility:
Public.

Description

Reland of "Remove void** from disk_cache interface" w/ blockfile iter fix. Enumeration and iteration were passing around void**. With this CL, we instead use an Iterator object. TBR=jkarlin@chromium.org,rvargas@chromium.org,clamy@chromium.org,piman@chromium.org BUG=413644, 416059 TEST=None Committed: https://crrev.com/b1aaa058d259c916a01b675ca297cc01c7a07b17 Cr-Commit-Position: refs/heads/master@{#296415}

Patch Set 1 #

Patch Set 2 : weakptr deletion fix #

Patch Set 3 : fix flake #

Patch Set 4 : fix fat finger #

Patch Set 5 : cleanup presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -403 lines) Patch
M content/browser/gpu/shader_disk_cache.cc View 1 2 5 chunks +17 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_cache.cc View 5 chunks +6 lines, -11 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 29 chunks +75 lines, -79 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl.h View 2 chunks +13 lines, -6 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl.cc View 2 3 7 chunks +48 lines, -34 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl_v3.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl_v3.cc View 2 chunks +30 lines, -16 lines 0 comments Download
M net/disk_cache/blockfile/in_flight_backend_io.h View 4 chunks +7 lines, -6 lines 0 comments Download
M net/disk_cache/blockfile/in_flight_backend_io.cc View 4 chunks +14 lines, -12 lines 0 comments Download
M net/disk_cache/blockfile/rankings.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/rankings.cc View 1 2 3 4 2 chunks +8 lines, -8 lines 0 comments Download
M net/disk_cache/disk_cache.h View 3 chunks +24 lines, -25 lines 0 comments Download
M net/disk_cache/disk_cache_test_base.h View 3 chunks +13 lines, -1 line 0 comments Download
M net/disk_cache/disk_cache_test_base.cc View 2 chunks +17 lines, -5 lines 0 comments Download
M net/disk_cache/entry_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/disk_cache/memory/mem_backend_impl.h View 4 chunks +7 lines, -4 lines 0 comments Download
M net/disk_cache/memory/mem_backend_impl.cc View 3 chunks +34 lines, -26 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.h View 7 chunks +9 lines, -36 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.cc View 4 chunks +71 lines, -87 lines 0 comments Download
M net/http/mock_http_cache.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/http/mock_http_cache.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M net/tools/dump_cache/simple_cache_dumper.h View 2 chunks +2 lines, -6 lines 0 comments Download
M net/tools/dump_cache/simple_cache_dumper.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M net/url_request/view_cache_helper.h View 2 chunks +2 lines, -6 lines 0 comments Download
M net/url_request/view_cache_helper.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
gavinp
This CL incorporates the (now twice reverted) code from https://codereview.chromium.org/583283002/ , along with the (already ...
6 years, 3 months ago (2014-09-22 16:44:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588243002/60001
6 years, 3 months ago (2014-09-24 01:46:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13026)
6 years, 3 months ago (2014-09-24 01:56:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588243002/80001
6 years, 3 months ago (2014-09-24 14:49:31 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 7192ea96dab00924762834cc11bb48df5f750e5b
6 years, 3 months ago (2014-09-24 14:54:46 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 14:55:23 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b1aaa058d259c916a01b675ca297cc01c7a07b17
Cr-Commit-Position: refs/heads/master@{#296415}

Powered by Google App Engine
This is Rietveld 408576698