Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 588223002: Fix SDF font positions when using global scale. (Closed)

Created:
6 years, 3 months ago by jvanverth1
Modified:
6 years, 3 months ago
Reviewers:
joshualitt, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix SDF font positions when using global scale. Also fixes a crash in the dftext GM when using SampleApp, and adds new test case in dftext. BUG=skia:2928 Committed: https://skia.googlesource.com/skia/+/76ce81e5e6c205dbb6344f9da51bfb7eba7bb43c

Patch Set 1 #

Patch Set 2 : Fix da bug; fix SampleApp crash #

Patch Set 3 : Some clean up #

Patch Set 4 : Delete unexpected file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -22 lines) Patch
M gm/dftext.cpp View 1 2 6 chunks +37 lines, -9 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 3 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jvanverth1
6 years, 3 months ago (2014-09-22 19:07:20 UTC) #2
egdaniel
lgtm
6 years, 3 months ago (2014-09-22 19:58:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588223002/60001
6 years, 3 months ago (2014-09-22 21:18:40 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 21:26:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 76ce81e5e6c205dbb6344f9da51bfb7eba7bb43c

Powered by Google App Engine
This is Rietveld 408576698