Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 588193004: Mojo: Have |ProxyMessagePipeEndpoint|s constructed with a |ChannelEndpoint|. (Closed)

Created:
6 years, 3 months ago by viettrungluu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Have |ProxyMessagePipeEndpoint|s constructed with a |ChannelEndpoint|. This eliminates the need for |ProxyMessagePipeEndpoint::Attach()|. R=brettw@chromium.org Committed: https://crrev.com/23ae8173cca87c9dd9ca71cf3142f75a88e43919 Cr-Commit-Position: refs/heads/master@{#296485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -169 lines) Patch
M mojo/embedder/embedder.cc View 7 chunks +16 lines, -17 lines 0 comments Download
M mojo/system/channel_unittest.cc View 3 chunks +15 lines, -9 lines 0 comments Download
M mojo/system/message_pipe.h View 2 chunks +11 lines, -7 lines 0 comments Download
M mojo/system/message_pipe.cc View 4 chunks +29 lines, -19 lines 0 comments Download
M mojo/system/message_pipe_dispatcher.h View 3 chunks +3 lines, -5 lines 0 comments Download
M mojo/system/message_pipe_dispatcher.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M mojo/system/message_pipe_perftest.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M mojo/system/message_pipe_test_utils.h View 3 chunks +8 lines, -4 lines 0 comments Download
M mojo/system/message_pipe_test_utils.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M mojo/system/multiprocess_message_pipe_unittest.cc View 8 chunks +22 lines, -15 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M mojo/system/remote_message_pipe_unittest.cc View 13 chunks +68 lines, -57 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
viettrungluu
6 years, 3 months ago (2014-09-22 17:51:58 UTC) #1
viettrungluu
-> brettw, since I hear he's eagerly looking for reviews to do (This is part ...
6 years, 3 months ago (2014-09-24 18:00:53 UTC) #3
brettw
lgtm
6 years, 3 months ago (2014-09-24 19:04:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588193004/1
6 years, 3 months ago (2014-09-24 19:17:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 27c49cce6da4553bda299b35fdf41d84ab58ecc5
6 years, 3 months ago (2014-09-24 19:23:24 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 19:24:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23ae8173cca87c9dd9ca71cf3142f75a88e43919
Cr-Commit-Position: refs/heads/master@{#296485}

Powered by Google App Engine
This is Rietveld 408576698