Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: ash/wm/overview/window_selector_unittest.cc

Issue 588193003: Defer maximize mode bounds updates until after exiting overview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/overview/window_selector_unittest.cc
diff --git a/ash/wm/overview/window_selector_unittest.cc b/ash/wm/overview/window_selector_unittest.cc
index bcbe8b0ceba1c6afe8231b030f73673e3b34b905..81594698bc02512e6d443d6798cd1e136dc9850d 100644
--- a/ash/wm/overview/window_selector_unittest.cc
+++ b/ash/wm/overview/window_selector_unittest.cc
@@ -17,6 +17,7 @@
#include "ash/test/shelf_view_test_api.h"
#include "ash/test/shell_test_api.h"
#include "ash/test/test_shelf_delegate.h"
+#include "ash/wm/maximize_mode/maximize_mode_controller.h"
#include "ash/wm/mru_window_tracker.h"
#include "ash/wm/overview/window_grid.h"
#include "ash/wm/overview/window_selector.h"
@@ -434,6 +435,46 @@ TEST_F(WindowSelectorTest, OverviewUndimsShelf) {
EXPECT_TRUE(shelf->GetDimsShelf());
}
+// Tests that entering overview when a fullscreen window is active in maximized
+// mode correctly applies the transformations to the window and correctly
+// updates the window bounds on exiting overview mode: http://crbug.com/401664.
+TEST_F(WindowSelectorTest, FullscreenWindowMaximizeMode) {
+ gfx::Rect bounds(0, 0, 400, 400);
+ scoped_ptr<aura::Window> window1(CreateWindow(bounds));
+ scoped_ptr<aura::Window> window2(CreateWindow(bounds));
+ Shell::GetInstance()->maximize_mode_controller()->
+ EnableMaximizeModeWindowManager(true);
+ wm::ActivateWindow(window2.get());
+ wm::ActivateWindow(window1.get());
+ gfx::Rect normal_window_bounds(window1->bounds());
+ const wm::WMEvent toggle_fullscreen_event(wm::WM_EVENT_TOGGLE_FULLSCREEN);
+ wm::GetWindowState(window1.get())->OnWMEvent(&toggle_fullscreen_event);
+ gfx::Rect fullscreen_window_bounds(window1->bounds());
+ EXPECT_NE(normal_window_bounds.ToString(),
+ fullscreen_window_bounds.ToString());
+ EXPECT_EQ(fullscreen_window_bounds.ToString(),
+ window2->GetTargetBounds().ToString());
+ ToggleOverview();
+ // Window 2 would normally resize to normal window bounds on showing the shelf
+ // for overview but this is deferred until overview is exited.
+ EXPECT_EQ(fullscreen_window_bounds.ToString(),
+ window2->GetTargetBounds().ToString());
+ EXPECT_FALSE(WindowsOverlapping(window1.get(), window2.get()));
+ ToggleOverview();
+
+ // Since the fullscreen window is still active, window2 will still have the
+ // larger bounds.
+ EXPECT_EQ(fullscreen_window_bounds.ToString(),
+ window2->GetTargetBounds().ToString());
+
+ // Enter overview again and select window 2. Selecting window 2 should show
+ // the shelf bringing window2 back to the normal bounds.
+ ToggleOverview();
+ ClickWindow(window2.get());
+ EXPECT_EQ(normal_window_bounds.ToString(),
+ window2->GetTargetBounds().ToString());
+}
+
// Tests that beginning window selection hides the app list.
TEST_F(WindowSelectorTest, SelectingHidesAppList) {
gfx::Rect bounds(0, 0, 400, 400);

Powered by Google App Engine
This is Rietveld 408576698