Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: pkg/compiler/lib/src/warnings.dart

Issue 588183002: Emit warning on import of dart:mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 const DONT_KNOW_HOW_TO_FIX = ""; 7 const DONT_KNOW_HOW_TO_FIX = "";
8 8
9 /** 9 /**
10 * The messages in this file should meet the following guide lines: 10 * The messages in this file should meet the following guide lines:
(...skipping 2208 matching lines...) Expand 10 before | Expand all | Expand 10 after
2219 "'#{constructorName}'."); 2219 "'#{constructorName}'.");
2220 2220
2221 static const MessageKind PATCH_NON_FUNCTION = const MessageKind( 2221 static const MessageKind PATCH_NON_FUNCTION = const MessageKind(
2222 "Cannot patch non-function with function patch " 2222 "Cannot patch non-function with function patch "
2223 "'#{functionName}'."); 2223 "'#{functionName}'.");
2224 2224
2225 ////////////////////////////////////////////////////////////////////////////// 2225 //////////////////////////////////////////////////////////////////////////////
2226 // Patch errors end. 2226 // Patch errors end.
2227 ////////////////////////////////////////////////////////////////////////////// 2227 //////////////////////////////////////////////////////////////////////////////
2228 2228
2229 static const String IMPORT_EXPERIMENTAL_MIRRORS_PADDING = '\n* ';
2230
2231 static const MessageKind IMPORT_EXPERIMENTAL_MIRRORS =
2232 const MessageKind(r'''
2233
2234 ****************************************************************
2235 * WARNING: dart:mirrors support in dart2js is experimental,
2236 * and not recommended.
2237 * This implementation of mirrors is incomplete,
2238 * and often greatly increases the size of the generated
2239 * JavaScript code.
2240 *
2241 * Your app imports dart:mirrors via:''''''
2242 $IMPORT_EXPERIMENTAL_MIRRORS_PADDING#{importChain}
2243 *
2244 * Starting with Dart 1.9, you must use the
2245 * --enable-experimental-mirrors command-line flag to opt-in.
2246 * You can begin using this flag now if mirrors support is critical.
2247 *
2248 * To learn what to do next, please visit:
2249 * http://dartlang.org/dart2js-reflection
2250 ****************************************************************
2251 ''');
2252
2229 static const MessageKind CALL_NOT_SUPPORTED_ON_NATIVE_CLASS = 2253 static const MessageKind CALL_NOT_SUPPORTED_ON_NATIVE_CLASS =
2230 const MessageKind( 2254 const MessageKind(
2231 "Non-supported 'call' member on a native class, or a " 2255 "Non-supported 'call' member on a native class, or a "
2232 "subclass of a native class."); 2256 "subclass of a native class.");
2233 2257
2234 toString() => template; 2258 toString() => template;
2235 2259
2236 Message message([Map arguments = const {}, bool terse = false]) { 2260 Message message([Map arguments = const {}, bool terse = false]) {
2237 return new Message(this, arguments, terse); 2261 return new Message(this, arguments, terse);
2238 } 2262 }
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
2286 static String convertToString(value) { 2310 static String convertToString(value) {
2287 if (value is ErrorToken) { 2311 if (value is ErrorToken) {
2288 // Shouldn't happen. 2312 // Shouldn't happen.
2289 return value.assertionMessage; 2313 return value.assertionMessage;
2290 } else if (value is Token) { 2314 } else if (value is Token) {
2291 value = value.value; 2315 value = value.value;
2292 } 2316 }
2293 return '$value'; 2317 return '$value';
2294 } 2318 }
2295 } 2319 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698