Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: pkg/compiler/lib/src/apiimpl.dart

Issue 588183002: Emit warning on import of dart:mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pkg/compiler/lib/src/compiler.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library leg_apiimpl; 5 library leg_apiimpl;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import '../compiler.dart' as api; 9 import '../compiler.dart' as api;
10 import 'dart2jslib.dart' as leg; 10 import 'dart2jslib.dart' as leg;
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 buildId: extractStringOption( 73 buildId: extractStringOption(
74 options, '--build-id=', 74 options, '--build-id=',
75 "build number could not be determined"), 75 "build number could not be determined"),
76 showPackageWarnings: 76 showPackageWarnings:
77 hasOption(options, '--show-package-warnings'), 77 hasOption(options, '--show-package-warnings'),
78 useContentSecurityPolicy: hasOption(options, '--csp'), 78 useContentSecurityPolicy: hasOption(options, '--csp'),
79 hasIncrementalSupport: 79 hasIncrementalSupport:
80 forceIncrementalSupport || 80 forceIncrementalSupport ||
81 hasOption(options, '--incremental-support'), 81 hasOption(options, '--incremental-support'),
82 suppressWarnings: hasOption(options, '--suppress-warnings'), 82 suppressWarnings: hasOption(options, '--suppress-warnings'),
83 enableExperimentalMirrors:
rmacnak 2015/01/14 18:30:29 Uhh, what do you intend to put behind this flag?
floitsch 2015/01/15 10:43:52 The implementation of dart:mirrors in dart2js is g
rmacnak 2015/01/15 21:48:52 The existing implementation? That's quite a signif
floitsch 2015/01/15 22:35:15 If adding a flag to a compilation process is a sig
84 hasOption(options, '--enable-experimental-mirrors'),
83 enableAsyncAwait: hasOption(options, '--enable-async'), 85 enableAsyncAwait: hasOption(options, '--enable-async'),
84 enableEnums: hasOption(options, '--enable-enum')) { 86 enableEnums: hasOption(options, '--enable-enum')) {
85 tasks.addAll([ 87 tasks.addAll([
86 userHandlerTask = new leg.GenericTask('Diagnostic handler', this), 88 userHandlerTask = new leg.GenericTask('Diagnostic handler', this),
87 userProviderTask = new leg.GenericTask('Input provider', this), 89 userProviderTask = new leg.GenericTask('Input provider', this),
88 ]); 90 ]);
89 if (!libraryRoot.path.endsWith("/")) { 91 if (!libraryRoot.path.endsWith("/")) {
90 throw new ArgumentError("libraryRoot must end with a /"); 92 throw new ArgumentError("libraryRoot must end with a /");
91 } 93 }
92 if (packageRoot != null && !packageRoot.path.endsWith("/")) { 94 if (packageRoot != null && !packageRoot.path.endsWith("/")) {
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 } 359 }
358 360
359 void diagnoseCrashInUserCode(String message, exception, stackTrace) { 361 void diagnoseCrashInUserCode(String message, exception, stackTrace) {
360 hasCrashed = true; 362 hasCrashed = true;
361 print('$message: ${tryToString(exception)}'); 363 print('$message: ${tryToString(exception)}');
362 print(tryToString(stackTrace)); 364 print(tryToString(stackTrace));
363 } 365 }
364 366
365 fromEnvironment(String name) => environment[name]; 367 fromEnvironment(String name) => environment[name];
366 } 368 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698