Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 588163003: Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407) (Closed)

Created:
6 years, 3 months ago by blink-deps-roller
Modified:
6 years, 3 months ago
Reviewers:
caseq, pdr., wjmaclean
CC:
chromium-reviews, caseq, pdr., wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407) Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/08e97a9..0f6e289 TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org Committed: https://crrev.com/f57e3cf2113ac892f16777e5ab225f3c68b94ede Cr-Commit-Position: refs/heads/master@{#295950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
blink-deps-roller
6 years, 3 months ago (2014-09-22 11:15:21 UTC) #1
blink-deps-roller
This roll was created by the Blink AutoRollBot. http://www.chromium.org/blink/blinkrollbot
6 years, 3 months ago (2014-09-22 11:15:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588163003/1
6 years, 3 months ago (2014-09-22 11:16:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as fe01a46ee282b844d53d71b550be403e922e49a9
6 years, 3 months ago (2014-09-22 12:18:30 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f57e3cf2113ac892f16777e5ab225f3c68b94ede Cr-Commit-Position: refs/heads/master@{#295950}
6 years, 3 months ago (2014-09-22 12:19:07 UTC) #6
vasilii
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/593743002/ by vasilii@chromium.org. ...
6 years, 3 months ago (2014-09-22 13:51:22 UTC) #7
vasilii
6 years, 3 months ago (2014-09-22 13:57:19 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/592783002/ by vasilii@chromium.org.

The reason for reverting is: Linux ASAN memory leaks after "Roll
src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407)"
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...

==30366==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 34 byte(s) in 1 object(s) allocated from:
#0 0x50482b in malloc
(/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x50482b)
#1 0x58b7516 in partitionAllocGenericFlags
third_party/WebKit/Source/wtf/PartitionAlloc.h:538:20
#2 0x58b7516 in partitionAllocGeneric
third_party/WebKit/Source/wtf/PartitionAlloc.h:554
#3 0x58b7516 in createUninitialized
third_party/WebKit/Source/wtf/text/StringImpl.cpp:299
#4 0x58b7516 in WTF::StringImpl::create(unsigned char const*, unsigned int)
third_party/WebKit/Source/wtf/text/StringImpl.cpp:418
#5 0x58e809f in WTF::String::fromUTF8(unsigned char const*, unsigned long)
third_party/WebKit/Source/wtf/text/WTFString.cpp:911:16
#6 0x58ffa2f in fromUTF8 third_party/WebKit/Source/wtf/text/WTFString.h:400:67
#7 0x58ffa2f in blink::WebString::fromUTF8(char const*, unsigned long)
third_party/WebKit/Source/platform/exported/WebString.cpp:91
#8 0x20a09ac in WebString<23>
third_party/WebKit/public/platform/WebString.h:113:16
#9 0x20a09ac in
content::MockMediaStreamRegistry::AddVideoTrack(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&)
content/renderer/media/mock_media_stream_registry.cc:36
#10 0x217484a in VideoSourceHandlerTest_OpenWithoutClose_Test
content/renderer/media/video_source_handler_unittest.cc:97:1
#11 0x217484a in
testing::internal::TestFactoryImpl<content::VideoSourceHandlerTest_OpenWithoutClose_Test>::CreateTest()
testing/gtest/include/gtest/internal/gtest-internal.h:486
#12 0x2f13c63 in
HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase,
testing::Test *> testing/gtest/src/gtest.cc:2418:12
#13 0x2f13c63 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2601
#14 0x2f14df6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5
#15 0x2f28853 in testing::internal::UnitTestImpl::RunAllTests()
testing/gtest/src/gtest.cc:4591:11
#16 0x2f27e54 in
HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>
testing/gtest/src/gtest.cc:2418:12
#17 0x2f27e54 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209
#18 0x2eb1e53 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10
#19 0x2eb1e53 in base::TestSuite::Run() base/test/test_suite.cc:226
#20 0x2ea717b in Run base/callback.h:401:12
#21 0x2ea717b in base::(anonymous
namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool,
base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498
#22 0x2ea6c70 in base::LaunchUnitTests(int, char**, base::Callback<int ()>
const&) base/test/launcher/unit_test_launcher.cc:553:10
#23 0x1ff5d0c in main content/test/run_all_unittests.cc:14:10
#24 0x7f375d21876c in __libc_start_main
/build/buildd/eglibc-2.15/csu/libc-start.c:226.

Powered by Google App Engine
This is Rietveld 408576698