[ServiceWorker] Plumbing the request mode from the renderer to the ServiceWorker. [2/2 chromium]

[ServiceWorker] Plumbing the request mode from the renderer to the ServiceWorker. [2/2 chromium]

[1/2] blink: https://codereview.chromium.org/587213003/
[2/2] chromium: https://codereview.chromium.org/588153002/

This value is passed from the renederer to the ServiceWorker in the following steps.

In the renederer process:
  blink::ResourceRequest::setFetchRequestMode()
 blink::ResourceRequest::m_fetchRequestMode
  content::WebURLLoaderImpl::Context::Start()
   blink::WebURLRequest::fetchRequestMode()
    GetFetchRequestMode()
 conetnt::RequestInfo::service_worker_request_mode

In the browser process:
 conetnt::RequestInfo::service_worker_request_mode
  content::ResourceDispatcherHostImpl::BeginRequest()
   content::ServiceWorkerRequestHandler::InitializeHandler()
    content::ServiceWorkerProviderHost::CreateRequestHandler()
     content::ServiceWorkerControlleeRequestHandler::ServiceWorkerControlleeRequestHandler()
 content::ServiceWorkerControlleeRequestHandler::request_mode_
  content::ServiceWorkerControlleeRequestHandler::MaybeCreateJob()
   content::ServiceWorkerURLRequestJob::ServiceWorkerURLRequestJob()
 content::ServiceWorkerURLRequestJob::request_mode_
  content::ServiceWorkerURLRequestJob::CreateFetchRequest()
 content::ServiceWorkerFetchRequest::mode

In the ServiceWorker process:
 content::ServiceWorkerFetchRequest::mode
  content::ServiceWorkerScriptContext::OnFetchEvent()
   GetBlinkFetchRequestMode()
   blink::WebServiceWorkerRequest::setMode()
 blink::WebServiceWorkerRequest::WebServiceWorkerRequestPrivate::m_mode
  blink::ServiceWorkerGlobalScopeProxy::dispatchFetchEvent()
   blilnk::RespondWithObserver::create()
 blilnk::RespondWithObserver::m_requestMode

 blink::WebServiceWorkerRequest::WebServiceWorkerRequestPrivate::m_mode
  blink::Request::create()
  blink::FetchRequestData::create()
 blink::FetchRequestData::m_mode

BUG=416371, 408507
Committed: https://crrev.com/7e40ec77f7b300c82c722b9927c5268ddc258294
Cr-Commit-Position: refs/heads/master@{#297391}

[horo, 2014-09-22 10:34:06]

Patchset #1 (id:1) has been deleted

[horo, 2014-09-22 10:34:12]

Patchset #1 (id:20001) has been deleted

[horo, 2014-09-22 10:38:08]

horo@chromium.org changed reviewers:
+ yhirano@chromium.org

[horo, 2014-09-22 10:38:08]

yhirano@
Could you please review?

[horo, 2014-09-25 03:57:28]

Patchset #3 (id:80001) has been deleted

[horo, 2014-09-25 04:05:41]

Patchset #3 (id:100001) has been deleted

[horo, 2014-09-25 04:07:15]

Patchset #2 (id:60001) has been deleted

[yhirano, 2014-09-25 11:37:30]

lgtm

[horo, 2014-09-25 14:06:40]

horo@chromium.org changed reviewers:
+ jochen@chromium.org

[horo, 2014-09-25 14:06:40]

jochen@
Could you please review content/child/*??

[horo, 2014-09-25 14:07:51]

horo@chromium.org changed reviewers:
+ nasko@chromium.org

[horo, 2014-09-25 14:07:51]

nasko@
Could you please review content/common/resource_messages.h and
content/common/service_worker/service_worker_messages.h?
Thank you.

[nasko, 2014-09-25 15:53:15]

IPC LGTM

[jochen (gone - plz use gerrit), 2014-09-29 12:56:44]

lgtm with nit

https://codereview.chromium.org/588153002/diff/160001/content/renderer/servic...
File content/renderer/service_worker/service_worker_script_context.cc (right):

https://codereview.chromium.org/588153002/diff/160001/content/renderer/servic...
content/renderer/service_worker/service_worker_script_context.cc:42: return
blink::WebURLRequest::FetchRequestModeSameOrigin;
nit. you could just use ASSERT_MATCHING_ENUM() and static_cast<> instead of this
switch (and the one above in the other direction).

[horo, 2014-09-30 02:15:39]

https://codereview.chromium.org/588153002/diff/160001/content/renderer/servic...
File content/renderer/service_worker/service_worker_script_context.cc (right):

https://codereview.chromium.org/588153002/diff/160001/content/renderer/servic...
content/renderer/service_worker/service_worker_script_context.cc:42: return
blink::WebURLRequest::FetchRequestModeSameOrigin;
On 2014/09/29 12:56:44, jochen wrote:
> nit. you could just use ASSERT_MATCHING_ENUM() and static_cast<> instead of
this
> switch (and the one above in the other direction).

Done.

[horo, 2014-09-30 06:58:05]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-09-30 06:58:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588153002/180001

[commit-bot: I haz the power, 2014-09-30 07:01:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-30 07:01:18]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/62314)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[horo, 2014-09-30 07:15:34]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-09-30 07:15:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588153002/180001

[commit-bot: I haz the power, 2014-09-30 07:19:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-30 07:19:23]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/62326)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[horo, 2014-09-30 07:30:45]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-09-30 07:31:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588153002/200001

[commit-bot: I haz the power, 2014-09-30 07:47:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-30 07:47:30]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2014-09-30 08:12:27]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-09-30 08:13:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588153002/220001

[commit-bot: I haz the power, 2014-09-30 08:26:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-30 08:26:10]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2014-09-30 08:32:35]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-09-30 08:33:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/588153002/240001

[commit-bot: I haz the power, 2014-09-30 09:23:53]

Committed patchset #8 (id:240001) as b103832ddfca6ce266c190b82153d7bc2e40b7c8

[commit-bot: I haz the power, 2014-09-30 09:24:33]

Patchset 8 (id:??) landed as
https://crrev.com/7e40ec77f7b300c82c722b9927c5268ddc258294
Cr-Commit-Position: refs/heads/master@{#297391}