Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 588143007: sandbox: Convert remaining legacy tests to use policy classes (Closed)

Created:
6 years, 3 months ago by mdempsky
Modified:
6 years, 3 months ago
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

sandbox: Convert remaining legacy tests to use policy classes BUG=414363 R=jln@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d84f4fc68ce38526ab417b3ad52aa76b102c421f

Patch Set 1 #

Patch Set 2 : Update build configs #

Patch Set 3 : Style fix #

Patch Set 4 : Update comments #

Patch Set 5 : Fix NaCl build #

Patch Set 6 : Another style fix (grr clang-format) #

Total comments: 14

Patch Set 7 : Respond to jln@ feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -186 lines) Patch
M components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc View 1 2 3 4 5 6 9 chunks +102 lines, -74 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tester_compatibility_delegate.h View 1 2 3 4 5 6 4 chunks +9 lines, -20 lines 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tests.h View 1 2 3 2 chunks +20 lines, -22 lines 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tests_unittest.cc View 1 2 3 4 5 6 2 chunks +17 lines, -15 lines 0 comments Download
D sandbox/linux/seccomp-bpf/sandbox_bpf_compatibility_policy.h View 1 chunk +0 lines, -42 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall_unittest.cc View 1 2 3 4 5 6 1 chunk +19 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mdempsky
6 years, 3 months ago (2014-09-22 23:56:19 UTC) #2
jln (very slow on Chromium)
lgtm with a minor nit. https://chromiumcodereview.appspot.com/588143007/diff/100001/sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc File sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc (right): https://chromiumcodereview.appspot.com/588143007/diff/100001/sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc#newcode221 sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc:221: BlacklistNanosleepTrapPolicy(int* aux) : aux_(aux) ...
6 years, 3 months ago (2014-09-23 18:42:06 UTC) #3
mdempsky
(Doh!) https://codereview.chromium.org/588143007/diff/100001/sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc File sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc (right): https://codereview.chromium.org/588143007/diff/100001/sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc#newcode221 sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc:221: BlacklistNanosleepTrapPolicy(int* aux) : aux_(aux) {} On 2014/09/23 18:42:06, ...
6 years, 3 months ago (2014-09-23 18:50:20 UTC) #4
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/d84f4fc68ce38526ab417b3ad52aa76b102c421f Cr-Commit-Position: refs/heads/master@{#296212}
6 years, 3 months ago (2014-09-23 20:08:20 UTC) #6
mdempsky
6 years, 3 months ago (2014-09-23 20:08:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as d84f4fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698