Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 588143006: cc: Re-enable tile eviction iterator test with occlusion. (Closed)

Created:
6 years, 3 months ago by vmpstr
Modified:
6 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Re-enable tile eviction iterator test with occlusion. This patch re-enables a patch that was timing out on windows. This code has changed significantly since it was disabled, and it's worth seeing if the problem went away. NOTE TO SHERIFFS ================ In case of a cc_unittest timeout (one of TileManager tests with occlusion), please revert this. I'll monitor how it goes, but I might miss it in the build. R=danakj BUG=401527 Committed: https://crrev.com/ccbb14469ac16c6936d5a62c02ed6319f2886772 Cr-Commit-Position: refs/heads/master@{#296038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M cc/resources/tile_manager_unittest.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
6 years, 3 months ago (2014-09-22 19:11:46 UTC) #2
danakj
LGTM
6 years, 3 months ago (2014-09-22 19:32:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588143006/1
6 years, 3 months ago (2014-09-22 19:37:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1b9f864da4c7db3eb8c6405e3761ef0215357c03
6 years, 3 months ago (2014-09-22 20:27:51 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 20:28:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccbb14469ac16c6936d5a62c02ed6319f2886772
Cr-Commit-Position: refs/heads/master@{#296038}

Powered by Google App Engine
This is Rietveld 408576698