Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 588143004: Introduce Props to surface (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Introduce Props to surface (patchset #27 id:520001 of https://codereview.chromium.org/551463004/)" This reverts commit 29c857d0f3a1cb837f73406eeb6ba9771879b5e7. TBR= Committed: https://skia.googlesource.com/skia/+/4a8126e7f81384526629b1e21bf89b632ea13cd9

Patch Set 1 #

Patch Set 2 : add legacy flag to skia_for_chromium #

Patch Set 3 : remove RenderTargetFlags from legacy mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+605 lines, -249 lines) Patch
M debugger/QT/SkGLWidget.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M dm/DMGpuSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M gm/dftext.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M gm/image.cpp View 1 chunk +1 line, -1 line 0 comments Download
A gm/surface.cpp View 1 chunk +109 lines, -0 lines 0 comments Download
M gm/xfermodes3.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkBitmapDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkCanvas.h View 5 chunks +17 lines, -4 lines 0 comments Download
M include/core/SkDevice.h View 2 chunks +3 lines, -1 line 0 comments Download
M include/core/SkSurface.h View 1 2 7 chunks +54 lines, -33 lines 0 comments Download
A include/core/SkSurfaceProps.h View 1 chunk +80 lines, -0 lines 0 comments Download
M include/pdf/SkPDFDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkNoSaveLayerCanvas.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 18 chunks +65 lines, -19 lines 0 comments Download
M src/core/SkDevice.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M src/core/SkDeviceProperties.h View 1 chunk +15 lines, -92 lines 0 comments Download
M src/core/SkPaint.cpp View 2 chunks +26 lines, -12 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecorder.h View 1 chunk +1 line, -1 line 0 comments Download
A src/core/SkSurfacePriv.h View 1 chunk +25 lines, -0 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 5 chunks +10 lines, -8 lines 0 comments Download
M src/image/SkSurface.cpp View 1 2 4 chunks +98 lines, -6 lines 0 comments Download
M src/image/SkSurface_Base.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 6 chunks +18 lines, -13 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 6 chunks +16 lines, -13 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkImageDecoder_CG.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/GpuDrawPathTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 4 chunks +6 lines, -0 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/ResourceCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/PictureRenderer.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588143004/40001
6 years, 3 months ago (2014-09-22 14:19:56 UTC) #2
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 4a8126e7f81384526629b1e21bf89b632ea13cd9
6 years, 3 months ago (2014-09-22 14:29:09 UTC) #3
reed1
6 years, 3 months ago (2014-09-22 14:29:23 UTC) #5
Message was sent while issue was closed. 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698