Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 58813002: Upon activation on mixed mode, we only show and use apps of the current user. Furthermore we should… (Closed)

Created:
7 years, 1 month ago by Mr4D (OOO till 08-26)
Modified:
7 years, 1 month ago
Reviewers:
xiyuan, James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Upon activation on mixed mode, we only show and use apps of the current user. Furthermore we should not show the menu if an app was created. BUG=296269 TEST=visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233142

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -36 lines) Patch
M ash/launcher/launcher_item_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M ash/shelf/app_list_shelf_item_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/app_list_shelf_item_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/shelf/shelf_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/shell/window_watcher_launcher_item_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_watcher_launcher_item_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/test/test_launcher_item_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_launcher_item_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 8 chunks +34 lines, -8 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_item_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mr4D (OOO till 08-26)
Please have a look!
7 years, 1 month ago (2013-11-05 02:42:39 UTC) #1
xiyuan
LGTM
7 years, 1 month ago (2013-11-05 03:12:02 UTC) #2
Mr4D (OOO till 08-26)
James, could I ask you for an owners review?
7 years, 1 month ago (2013-11-05 04:22:56 UTC) #3
James Cook
LGTM with one question https://codereview.chromium.org/58813002/diff/1/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc File chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc (right): https://codereview.chromium.org/58813002/diff/1/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc#newcode228 chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc:228: return false; Should this be ...
7 years, 1 month ago (2013-11-05 17:29:39 UTC) #4
Mr4D (OOO till 08-26)
Thanks for your review! https://codereview.chromium.org/58813002/diff/1/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc File chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc (right): https://codereview.chromium.org/58813002/diff/1/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc#newcode228 chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc:228: return false; You are correct! ...
7 years, 1 month ago (2013-11-05 18:02:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/58813002/80001
7 years, 1 month ago (2013-11-05 18:10:15 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=185277
7 years, 1 month ago (2013-11-05 20:22:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/58813002/80001
7 years, 1 month ago (2013-11-05 20:59:46 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 23:50:25 UTC) #9
Message was sent while issue was closed. 
Change committed as 233142

Powered by Google App Engine
This is Rietveld 408576698