Change Widget::GetAllOwnedWidgets to return child widgets as well

ui/views/widget/native_widget_aura.cc

Index: ui/views/widget/native_widget_aura.cc
diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc
index 41a58c5fbb5aee9b23bc20317698fb6e52a09741..00db05bd2764520e8a8ac2de8f1ce574fa6e701d 100644
--- a/ui/views/widget/native_widget_aura.cc
+++ b/ui/views/widget/native_widget_aura.cc
@@ -1105,6 +1105,7 @@ void NativeWidgetPrivate::GetAllChildWidgets(gfx::NativeView native_view,
 // static
 void NativeWidgetPrivate::GetAllOwnedWidgets(gfx::NativeView native_view,

[tapted, 2014/10/15 23:59:24]

you'll need to update the comment in widget.h

https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/widget/wi...

[sashab, 2014/10/20 03:03:00]

Done to just remove 'non-child'. Didn't think I needed to be explicit about
including children.

                                              Widget::Widgets* owned) {
+  // Add all owned widgets.
   const aura::Window::Windows& transient_children =
       wm::GetTransientChildren(native_view);
   for (aura::Window::Windows::const_iterator i = transient_children.begin();
@@ -1115,6 +1116,14 @@ void NativeWidgetPrivate::GetAllOwnedWidgets(gfx::NativeView native_view,
       owned->insert(native_widget->GetWidget());
     GetAllOwnedWidgets((*i), owned);
   }
+
+  // Add all owned windows.

[tapted, 2014/10/15 23:59:24]

owned windows -> child windows

[sashab, 2014/10/20 03:03:00]

Done.

+  const aura::Window::Windows& child_windows = native_view->children();
+  for (aura::Window::Windows::const_iterator i = child_windows.begin();

[tapted, 2014/10/15 23:59:24]

might as well start using C++11. Pretty sure this becomes just

for (const auto& child : native_view->children())
  GetAllChildWidgets(child, owned);

the other loop in this function should be updated too

[sashab, 2014/10/20 03:03:00]

Done. Git cl format wants to change "x->y()" to "x -> y()" but I prevented it...
Looking for a place to file bugs on clang-format.

+       i != child_windows.end();
+       ++i) {
+    GetAllChildWidgets((*i), owned);
+  }
 }
 
 // static