Change Widget::GetAllOwnedWidgets to return child widgets as well

ui/views/accessibility/native_view_accessibility_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/accessibility/native_view_accessibility_win.h"
 
 #include <oleacc.h>
 #include <UIAutomationClient.h>
 
 #include <set>
@@ skipping 1473 matching lines @@
       text, line_breaks, boundary, start_offset, direction);
 }
 
 void NativeViewAccessibilityWin::PopulateChildWidgetVector(
     std::vector<Widget*>* result_child_widgets) {
   const Widget* widget = view()->GetWidget();
   if (!widget)
     return;
 
   std::set<Widget*> child_widgets;
-  Widget::GetAllChildWidgets(widget->GetNativeView(), &child_widgets);

[sashab, 2014/10/20 03:03:01]

Originally, this function was taking the concatenation of all the child and
owned widgets. Now it should still get both the child and owned widgets - the
only widget missing is the one for widget->GetNativeView() itself. However, see
below...

   Widget::GetAllOwnedWidgets(widget->GetNativeView(), &child_widgets);
   for (std::set<Widget*>::const_iterator iter = child_widgets.begin();
            iter != child_widgets.end(); ++iter) {
     Widget* child_widget = *iter;
     if (child_widget == widget)

[sashab, 2014/10/20 03:03:01]

... their own widget is ignored anyway. Leaving this if-statement in for clarity
but it shouldn't change the behaviour now that this widget is missing from the
list.

[tapted, 2014/10/20 04:40:05]

If it's just for clarity, something like

DCHECK_NE(widget, child_widget);

would be more appropriate

[sashab, 2014/10/20 05:15:34]

Good idea; done.

       continue;
 
     if (!child_widget->IsVisible())
       continue;
 
     if (widget->GetNativeWindowProperty(kWidgetNativeViewHostKey))
       continue;
 
     result_child_widgets->push_back(child_widget);
   }
@@ skipping 21 matching lines @@
     if (view == NULL || view == view_) {
       alert_target_view_storage_ids_.erase(
           alert_target_view_storage_ids_.begin() + i);
     } else {
       ++i;
     }
   }
 }
 
 }  // namespace views