Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 588093003: [ServiceWorker] Add test for the rejected result of FetchEvent using XHR. (Closed)

Created:
6 years, 3 months ago by horo
Modified:
6 years, 3 months ago
Reviewers:
yhirano
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Add test for the rejected result of FetchEvent using XHR. Step1: [ServiceWorker] Remove the test for the rejected result of FetchEvent from fetch-event.html https://codereview.chromium.org/588993002/ Step2: [ServiceWorker] Treat the rejected result of onFetch as a Network Error. https://codereview.chromium.org/590043002/ Step3: this patch [ServiceWorker] Add test for the rejected result of FetchEvent using XHR. https://codereview.chromium.org/588093003/ BUG=411173 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182471

Patch Set 1 #

Total comments: 2

Patch Set 2 : add resolve-null test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M LayoutTests/http/tests/serviceworker/resources/fetch-cors-xhr-iframe.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/fetch-rewrite-worker.js View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
horo
yhirano@ Could you please review?
6 years, 3 months ago (2014-09-22 05:29:42 UTC) #2
yhirano
lgtm https://codereview.chromium.org/588093003/diff/1/LayoutTests/http/tests/serviceworker/resources/fetch-cors-xhr-iframe.html File LayoutTests/http/tests/serviceworker/resources/fetch-cors-xhr-iframe.html (right): https://codereview.chromium.org/588093003/diff/1/LayoutTests/http/tests/serviceworker/resources/fetch-cors-xhr-iframe.html#newcode45 LayoutTests/http/tests/serviceworker/resources/fetch-cors-xhr-iframe.html:45: return create_failure_test_promise('./dummy?reject', false); Do we have a test ...
6 years, 3 months ago (2014-09-22 07:42:51 UTC) #3
horo
https://codereview.chromium.org/588093003/diff/1/LayoutTests/http/tests/serviceworker/resources/fetch-cors-xhr-iframe.html File LayoutTests/http/tests/serviceworker/resources/fetch-cors-xhr-iframe.html (right): https://codereview.chromium.org/588093003/diff/1/LayoutTests/http/tests/serviceworker/resources/fetch-cors-xhr-iframe.html#newcode45 LayoutTests/http/tests/serviceworker/resources/fetch-cors-xhr-iframe.html:45: return create_failure_test_promise('./dummy?reject', false); On 2014/09/22 07:42:51, yhirano wrote: > ...
6 years, 3 months ago (2014-09-22 09:00:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588093003/20001
6 years, 3 months ago (2014-09-23 05:23:22 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 06:59:56 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 182471

Powered by Google App Engine
This is Rietveld 408576698