Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 588073004: Specify system framework dependencies properly in .gyp files (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M tools/tools.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M util/util.gyp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-22 18:04:07 UTC) #2
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-22 18:05:35 UTC) #3
Mark Mentovai
6 years, 3 months ago (2014-09-22 18:06:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 0d8f67c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698