Sync PRESUBMIT.py with what is run on CQ.

Sync PRESUBMIT.py with what is run on CQ.

This is a repeat of https://chromiumcodereview.appspot.com/11553016/, using the
New Advanced Technology™ in https://chromiumcodereview.appspot.com/54373011/.

BUG=278554
R=maruel@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233509

[ghost stip (do not use), 2013-11-05 02:34:40]

ptal

[M-A Ruel, 2013-11-05 03:59:28]

https://codereview.chromium.org/58803002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/58803002/diff/1/PRESUBMIT.py#newcode1007
PRESUBMIT.py:1007: # To add tests to this list, they MUST be in
It could be a docstring. Also document that |bots| is a whitelist.

https://codereview.chromium.org/58803002/diff/1/PRESUBMIT.py#newcode1020
PRESUBMIT.py:1020: #'url_unittests',
The test was renamed from googleurl, hence the improper sorting, please move it
back.

https://codereview.chromium.org/58803002/diff/1/PRESUBMIT.py#newcode1037
PRESUBMIT.py:1037: # Note: *_aura are Release builders even if their names
convey otherwise.
Do we still have non-aura builder for Windows? Probably worth clearing this up
while at it.

https://codereview.chromium.org/58803002/diff/1/PRESUBMIT.py#newcode1195
PRESUBMIT.py:1195: return GetDefaultTryConfigs(['android_aosp', 'android_dbg',
Keep one entry per line. Since this is the kind of file that may be modified by
various people, it's easier when separation is clearer.

https://codereview.chromium.org/58803002/diff/1/PRESUBMIT.py#newcode1224
PRESUBMIT.py:1224: trybots += GetDefaultTryConfigs(['linux_chromeos_clang'])
I highly prefer explicit append/extend.

[ghost stip (do not use), 2013-11-05 22:59:19]

ptal

https://chromiumcodereview.appspot.com/58803002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/58803002/diff/1/PRESUBMIT.py#newcode1007
PRESUBMIT.py:1007: # To add tests to this list, they MUST be in
On 2013/11/05 03:59:28, M-A Ruel wrote:
> It could be a docstring. Also document that |bots| is a whitelist.

Done.

https://chromiumcodereview.appspot.com/58803002/diff/1/PRESUBMIT.py#newcode1020
PRESUBMIT.py:1020: #'url_unittests',
On 2013/11/05 03:59:28, M-A Ruel wrote:
> The test was renamed from googleurl, hence the improper sorting, please move
it
> back.

Done.

https://chromiumcodereview.appspot.com/58803002/diff/1/PRESUBMIT.py#newcode1037
PRESUBMIT.py:1037: # Note: *_aura are Release builders even if their names
convey otherwise.
On 2013/11/05 03:59:28, M-A Ruel wrote:
> Do we still have non-aura builder for Windows? Probably worth clearing this up
> while at it.

waiting on kbr/egr's comments

https://chromiumcodereview.appspot.com/58803002/diff/1/PRESUBMIT.py#newcode1195
PRESUBMIT.py:1195: return GetDefaultTryConfigs(['android_aosp', 'android_dbg',
On 2013/11/05 03:59:28, M-A Ruel wrote:
> Keep one entry per line. Since this is the kind of file that may be modified
by
> various people, it's easier when separation is clearer.

Done.

https://chromiumcodereview.appspot.com/58803002/diff/1/PRESUBMIT.py#newcode1224
PRESUBMIT.py:1224: trybots += GetDefaultTryConfigs(['linux_chromeos_clang'])
On 2013/11/05 03:59:28, M-A Ruel wrote:
> I highly prefer explicit append/extend.

Done.

[M-A Ruel, 2013-11-06 00:29:19]

lgtm pending figuring aura.

[commit-bot: I haz the power, 2013-11-07 02:07:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stip@chromium.org/58803002/100001

[commit-bot: I haz the power, 2013-11-07 06:42:37]

Change committed as 233509