Source/core/rendering/RenderLayerScrollableArea.cpp - Issue 588013002: Remove Overlay Scrollbar if not scrollable along the axis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayerScrollableArea.cpp

Issue 588013002: Remove Overlay Scrollbar if not scrollable along the axis (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added test expectations Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/TestExpectations ('K') | « LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.png ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderLayerScrollableArea.cpp

diff --git a/Source/core/rendering/RenderLayerScrollableArea.cpp b/Source/core/rendering/RenderLayerScrollableArea.cpp

index 308e7016e74a1e8f5cd0b1f9acb5855104f009e1..f98b2fe75357b867b04c9af218c0a993abd976c0 100644

--- a/Source/core/rendering/RenderLayerScrollableArea.cpp

+++ b/Source/core/rendering/RenderLayerScrollableArea.cpp

@@ -1006,6 +1006,13 @@ void RenderLayerScrollableArea::paintOverflowControls(GraphicsContext* context,

if (!box().hasOverflowClip())

return;

+ if (hasOverlayScrollbars()) {

+ if (!scrollSize(HorizontalScrollbar))

+ destroyScrollbar(HorizontalScrollbar);

+ if (!scrollSize(VerticalScrollbar))

+ destroyScrollbar(VerticalScrollbar);

+ }

IntPoint adjustedPaintOffset = paintOffset;

if (paintingOverlayControls)

adjustedPaintOffset = m_cachedOverlayScrollbarOffset;