Source/core/rendering/RenderLayerScrollableArea.cpp - Issue 588013002: Remove Overlay Scrollbar if not scrollable along the axis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayerScrollableArea.cpp

Issue 588013002: Remove Overlay Scrollbar if not scrollable along the axis (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: final Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/select/listbox-overlay-scrollbar.html ('K') | « LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderLayerScrollableArea.cpp

diff --git a/Source/core/rendering/RenderLayerScrollableArea.cpp b/Source/core/rendering/RenderLayerScrollableArea.cpp

index d5ba03a633bf3881c315a8f3d19516e7f4c4015f..31d6e634fc3ad48dede7fc4ce142f375d5b143c3 100644

--- a/Source/core/rendering/RenderLayerScrollableArea.cpp

+++ b/Source/core/rendering/RenderLayerScrollableArea.cpp

@@ -600,7 +600,12 @@ void RenderLayerScrollableArea::updateAfterLayout()

if (box().style()->overflowY() == OSCROLL)

verticalScrollbar()->setEnabled(hasVerticalOverflow);

}

+ if (hasOverlayScrollbars()) {

+ if (!scrollSize(HorizontalScrollbar))

+ setHasHorizontalScrollbar(false);

+ if (!scrollSize(VerticalScrollbar))

+ setHasVerticalScrollbar(false);

+ }

// overflow:auto may need to lay out again if scrollbars got added/removed.

bool autoHorizontalScrollBarChanged = box().hasAutoHorizontalScrollbar() && (hasHorizontalScrollbar() != hasHorizontalOverflow);

bool autoVerticalScrollBarChanged = box().hasAutoVerticalScrollbar() && (hasVerticalScrollbar() != hasVerticalOverflow);