Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 588013002: Remove Overlay Scrollbar if not scrollable along the axis (Closed)

Created:
6 years, 3 months ago by MuVen
Modified:
6 years, 2 months ago
Reviewers:
Ian Vollick, enne (OOO)
CC:
aelias_OOO_until_Jul13, blink-reviews, danakj, Sikugu_, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove Overlay Scrollbar if not scrollable along the axis Remove Overlay Scrollbar if not scrollable along that axis. If the scrollSize along that axis is zero then set scrollbar along that axis to false. This is applicable to Solid-Color scrollbars in Android & Overlay scrollbars in the Aura. BUG=415031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183445

Patch Set 1 #

Patch Set 2 : MainFrameScrollbars are not fadedout. Fix for the same. #

Patch Set 3 : Destroy Overlay Scrollbar On Zero Scroll Size #

Patch Set 4 : added test #

Patch Set 5 : fixing layout test #

Patch Set 6 : fixing layout failure #

Patch Set 7 : added test expectations #

Total comments: 3

Patch Set 8 : final #

Total comments: 2

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -58 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/select/listbox-nooverlay-scrollbar.html View 1 2 3 4 5 6 7 8 1 chunk +1 line, -2 lines 0 comments Download
A LayoutTests/fast/forms/select/listbox-nooverlay-scrollbar-expected.html View 1 2 3 4 5 6 7 8 1 chunk +25 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/select/listbox-overlay-scrollbar.html View 1 2 3 4 5 6 7 8 2 chunks +16 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/select/listbox-overlay-scrollbar-expected.html View 1 2 3 4 5 6 7 2 chunks +13 lines, -0 lines 0 comments Download
M LayoutTests/fast/scrolling/overlay-scrollbars.html View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -2 lines 0 comments Download
M LayoutTests/fast/scrolling/overlay-scrollbars-expected.html View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -11 lines 0 comments Download
A + LayoutTests/platform/linux/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.png View 1 2 3 4 5 6 7 Binary file 0 comments Download
A + LayoutTests/platform/linux/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -9 lines 0 comments Download
A + LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.png View 1 2 3 4 5 6 7 Binary file 0 comments Download
A + LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -9 lines 0 comments Download
M LayoutTests/platform/win/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.png View 1 2 3 4 5 6 7 Binary file 0 comments Download
M LayoutTests/platform/win/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -11 lines 0 comments Download
M LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.png View 1 2 3 4 5 6 7 Binary file 0 comments Download
M LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -11 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 95 (59 generated)
MuVen
PTAL.
6 years, 3 months ago (2014-09-20 14:17:25 UTC) #2
MuVen
+weiliangc, vivekg
6 years, 3 months ago (2014-09-20 14:18:52 UTC) #4
MuVen
PTAL.
6 years, 3 months ago (2014-09-22 14:04:20 UTC) #8
weiliangc
On 2014/09/22 14:04:20, muven wrote: > PTAL. This is not a Android only problem. One ...
6 years, 3 months ago (2014-09-22 21:40:18 UTC) #9
MuVen
Hi Enne, PTAL. Thanks, MuVen.
6 years, 3 months ago (2014-09-24 12:01:11 UTC) #13
enne (OOO)
Can you write a test for this?
6 years, 3 months ago (2014-09-24 16:52:03 UTC) #15
MuVen
PTAL.
6 years, 2 months ago (2014-09-25 13:23:16 UTC) #16
MuVen
This needs new test or can modify current tests ?
6 years, 2 months ago (2014-09-25 13:32:03 UTC) #17
enne (OOO)
Thanks, that test seems reasonable to me. Can you examine the test failures and see ...
6 years, 2 months ago (2014-09-25 17:19:34 UTC) #18
MuVen
PTAL. Thanks,
6 years, 2 months ago (2014-09-26 12:04:35 UTC) #20
enne (OOO)
https://codereview.chromium.org/588013002/diff/200001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/588013002/diff/200001/LayoutTests/TestExpectations#newcode1344 LayoutTests/TestExpectations:1344: crbug.com/415031 [ Mac ] fast/forms/select/listbox-overlay-scrollbar.html [ ImageOnlyFailure ] Why ...
6 years, 2 months ago (2014-09-26 17:35:48 UTC) #21
MuVen
On 2014/09/26 17:35:48, enne wrote: > https://codereview.chromium.org/588013002/diff/200001/LayoutTests/TestExpectations > File LayoutTests/TestExpectations (right): > > https://codereview.chromium.org/588013002/diff/200001/LayoutTests/TestExpectations#newcode1344 > ...
6 years, 2 months ago (2014-09-29 13:13:11 UTC) #38
MuVen
https://codereview.chromium.org/588013002/diff/200001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/588013002/diff/200001/LayoutTests/TestExpectations#newcode1344 LayoutTests/TestExpectations:1344: crbug.com/415031 [ Mac ] fast/forms/select/listbox-overlay-scrollbar.html [ ImageOnlyFailure ] On ...
6 years, 2 months ago (2014-09-30 12:49:48 UTC) #42
enne (OOO)
On 2014/09/30 at 12:49:48, sataya.m wrote: > https://codereview.chromium.org/588013002/diff/200001/LayoutTests/TestExpectations > File LayoutTests/TestExpectations (right): > > https://codereview.chromium.org/588013002/diff/200001/LayoutTests/TestExpectations#newcode1344 ...
6 years, 2 months ago (2014-10-01 18:13:11 UTC) #43
MuVen
On 2014/10/01 18:13:11, enne wrote: > On 2014/09/30 at 12:49:48, sataya.m wrote: > > > ...
6 years, 2 months ago (2014-10-01 23:48:19 UTC) #44
enne (OOO)
I don't understand what you mean by "the build bot is not picking up the ...
6 years, 2 months ago (2014-10-02 15:25:17 UTC) #45
MuVen
On 2014/10/02 15:25:17, enne wrote: > I don't understand what you mean by "the build ...
6 years, 2 months ago (2014-10-02 17:07:01 UTC) #46
enne (OOO)
On 2014/10/02 at 17:07:01, sataya.m wrote: > On 2014/10/02 15:25:17, enne wrote: > > I ...
6 years, 2 months ago (2014-10-02 18:19:15 UTC) #47
MuVen
Hi enne, https://storage.googleapis.com/chromium-layout-test-archives/mac_blink_rel/25249/layout-test-results/results.html is the result of mac_blink_rel bot which i have triggered with some ...
6 years, 2 months ago (2014-10-03 02:56:02 UTC) #48
MuVen
Hi enne, i have upload patchset 10 and this also in which mac bot has ...
6 years, 2 months ago (2014-10-03 12:59:26 UTC) #53
weiliangc
On 2014/10/03 12:59:26, muven wrote: > Hi enne, > > i have upload patchset 10 ...
6 years, 2 months ago (2014-10-03 14:36:50 UTC) #54
MuVen
On 2014/10/03 14:36:50, weiliangc wrote: > On 2014/10/03 12:59:26, muven wrote: > > Hi enne, ...
6 years, 2 months ago (2014-10-03 16:04:22 UTC) #55
MuVen
On 2014/10/03 16:04:22, muven wrote: > On 2014/10/03 14:36:50, weiliangc wrote: > > On 2014/10/03 ...
6 years, 2 months ago (2014-10-03 16:06:57 UTC) #56
MuVen
Hi Enne, I have fixed all the issues. PTAL. Thanks, Muven. https://codereview.chromium.org/588013002/diff/200001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): ...
6 years, 2 months ago (2014-10-06 13:34:27 UTC) #79
MuVen
On 2014/10/06 13:34:27, muven wrote: > Hi Enne, > > I have fixed all the ...
6 years, 2 months ago (2014-10-07 17:29:52 UTC) #80
enne (OOO)
https://codereview.chromium.org/588013002/diff/1120001/LayoutTests/fast/forms/select/listbox-overlay-scrollbar.html File LayoutTests/fast/forms/select/listbox-overlay-scrollbar.html (right): https://codereview.chromium.org/588013002/diff/1120001/LayoutTests/fast/forms/select/listbox-overlay-scrollbar.html#newcode33 LayoutTests/fast/forms/select/listbox-overlay-scrollbar.html:33: <option>foo1</option> Can you tell me why you needed to ...
6 years, 2 months ago (2014-10-07 18:57:22 UTC) #81
MuVen
https://codereview.chromium.org/588013002/diff/1120001/LayoutTests/fast/forms/select/listbox-overlay-scrollbar.html File LayoutTests/fast/forms/select/listbox-overlay-scrollbar.html (right): https://codereview.chromium.org/588013002/diff/1120001/LayoutTests/fast/forms/select/listbox-overlay-scrollbar.html#newcode33 LayoutTests/fast/forms/select/listbox-overlay-scrollbar.html:33: <option>foo1</option> This test is for to check overlay scrollbar ...
6 years, 2 months ago (2014-10-07 23:45:42 UTC) #82
MuVen
sorry.to explain in detail this test case is to ensure that listbox also renders the ...
6 years, 2 months ago (2014-10-08 00:41:37 UTC) #83
enne (OOO)
Thanks, that makes a lot of sense to have the listbox test continue to test ...
6 years, 2 months ago (2014-10-08 00:52:28 UTC) #84
MuVen
I have uploaded listbox-nooverlay-scrollbar.html which disappears the overlay scrollbar on empty listbox size.
6 years, 2 months ago (2014-10-08 14:07:26 UTC) #85
enne (OOO)
lgtm Thanks for all the test investigations and changes.
6 years, 2 months ago (2014-10-08 20:41:49 UTC) #86
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588013002/1140001
6 years, 2 months ago (2014-10-08 20:43:02 UTC) #88
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-09 02:35:45 UTC) #90
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588013002/1140001
6 years, 2 months ago (2014-10-09 05:32:34 UTC) #92
commit-bot: I haz the power
Committed patchset #9 (id:1140001) as 183445
6 years, 2 months ago (2014-10-09 06:49:20 UTC) #93
apavlov
6 years, 2 months ago (2014-10-10 08:19:49 UTC) #94
Message was sent while issue was closed.
A revert of this CL (patchset #9 id:1140001) has been created in
https://codereview.chromium.org/643033002/ by apavlov@chromium.org.

The reason for reverting is: This has tentatively resulted in multiple
webkit_unit_tests crashes on android_dbg_tests_recipe, blocking a Blink roll..

Powered by Google App Engine
This is Rietveld 408576698