Issue 5880003: fix a couple of close buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5880003: fix a couple of close buttons (Closed)

Created:
10 years ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

fix a couple of close buttons the gtk extension installed button doesn't need to be themed because the background is always white (and is not the tab color, like it is in most other places in the UI) the list item x isn't changing (the images are the same), only the URL is changing. I think this is the 'x' we want, because it's what we use on the NTP. BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69497

Patch Set 1 #

Patch Set 2 : fix #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -9 lines)			Patch
	M	chrome/browser/gtk/extension_installed_bubble_gtk.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
	M	chrome/browser/resources/options/options_page.css	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages