Fix doodle verification URL.

components/search_provider_logos/logo_tracker_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/search_provider_logos/logo_tracker.h"
 
 #include <vector>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 353 matching lines @@
     net::HttpStatusCode response_code) {
   fake_url_fetcher_factory_.SetFakeResponse(
       logo_url_, response, response_code, request_status);
 }
 
 void LogoTrackerTest::SetServerResponseWhenFingerprint(
     const std::string& fingerprint,
     const std::string& response_when_fingerprint,
     net::URLRequestStatus::Status request_status,
     net::HttpStatusCode response_code) {
-  GURL url_with_fp =
-      net::AppendQueryParameter(logo_url_, "async", "es_dfp:" + fingerprint);
+  GURL url_with_fp = net::AppendQueryParameter(logo_url_, "async", "es_dfp");
+  url_with_fp = GURL(url_with_fp.spec() + ":" + fingerprint);

[mmenke, 2014/09/23 21:16:17]

This seems really ugly.

You're basically relying on GURL's escaping behavior being different from net's
(Which itself is hideous).  net's behavior looks to be the more correct one here
- RFC 2396 (https://www.ietf.org/rfc/rfc2396.txt) pretty clearly indicates the
colon is reserved in the query component.

Of course, "fixing" GURL here may well break a bunch of sites, so it may make
more sense to "fix" escape.h instead, ideally by making it wrap the GURL code. 
This could cause unexpected regressions as well, however, so I don't think
either option is a merge candidate.

I don't suppose we could just fix the server code?

   fake_url_fetcher_factory_.SetFakeResponse(
       url_with_fp, response_when_fingerprint, response_code, request_status);
 }
 
 void LogoTrackerTest::GetLogo() {
   logo_tracker_->GetLogo(&observer_);
   base::RunLoop().RunUntilIdle();
 }
 
 // Tests -----------------------------------------------------------------------
@@ skipping 273 matching lines @@
   MockLogoObserver listener2;
   listener2.ExpectFreshLogo(&logo);
   logo_tracker_->GetLogo(&listener2);
 
   base::RunLoop().RunUntilIdle();
 }
 
 }  // namespace
 
 }  // namespace search_provider_logos